Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5281

concurrent_select.py still not failing when there is a results mismatch

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: Impala 2.9.0
    • Fix Version/s: Impala 2.10.0
    • Component/s: Infrastructure
    • Labels:
      None

      Description

      If the stress test runs against a buggy Impala that is not returning correct results, a hash sum mismatch is noted in logs, but the concurrent_select.py process will still finish with exit success.

      I thought this had been fixed, but apparently not. --fail-upon-successive-errors might be related.

        Issue Links

          Activity

          Show
          mikesbrown Michael Brown added a comment - https://gerrit.cloudera.org/#/c/7282/
          Hide
          mikesbrown Michael Brown added a comment -
          commit f4c82bf540f2aa54bb9180231e6e5063d35ae824
          Author: Michael Brown <mikeb@cloudera.com>
          Date:   Tue Jun 20 13:02:50 2017 -0700
          
              IMPALA-5281: stress test: introduce stricter pass guidelines
          
              1. Report incorrect results count in the console log table. Previously,
              the stress test knew about incorrect results but only reported them to
              the console log inline. In was on the onus of a caller to find this. Now
              we have a summed count.
          
              2. Fail the process if there are errors, incorrect results, or timeouts.
              Previously, the stress test just counted these, but would not fail its
              process. This leads to a much stricter pass criteria for the stress
              test. This will allow CI to fail and alert a maintainer that something
              went wrong.
          
              Testing:
          
              I modified the result hashes for queries in a local runtime_info.json
              and observed the reporting of incorrect results, incremented incorrect
              results counts, and ultimately process failure.
          
              Change-Id: I9f2174a527193ae01be45b8ed56315c465883346
              Reviewed-on: http://gerrit.cloudera.org:8080/7282
              Reviewed-by: Michael Brown <mikeb@cloudera.com>
              Tested-by: Impala Public Jenkins
          
          Show
          mikesbrown Michael Brown added a comment - commit f4c82bf540f2aa54bb9180231e6e5063d35ae824 Author: Michael Brown <mikeb@cloudera.com> Date: Tue Jun 20 13:02:50 2017 -0700 IMPALA-5281: stress test: introduce stricter pass guidelines 1. Report incorrect results count in the console log table. Previously, the stress test knew about incorrect results but only reported them to the console log inline. In was on the onus of a caller to find this. Now we have a summed count. 2. Fail the process if there are errors, incorrect results, or timeouts. Previously, the stress test just counted these, but would not fail its process. This leads to a much stricter pass criteria for the stress test. This will allow CI to fail and alert a maintainer that something went wrong. Testing: I modified the result hashes for queries in a local runtime_info.json and observed the reporting of incorrect results, incremented incorrect results counts, and ultimately process failure. Change-Id: I9f2174a527193ae01be45b8ed56315c465883346 Reviewed-on: http://gerrit.cloudera.org:8080/7282 Reviewed-by: Michael Brown <mikeb@cloudera.com> Tested-by: Impala Public Jenkins

            People

            • Assignee:
              mikesbrown Michael Brown
              Reporter:
              mikesbrown Michael Brown
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development