Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5258

Need to reenable building Impala-lzo in release mode

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Impala 2.9.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Backend
    • Labels:
      None
    • Epic Color:
      ghx-label-9

      Description

      In IMPALA-5172, we disabled building Impala-lzo in RELEASE mode by always passing in DEBUG as the CMAKE_BUILD_TYPE, as hdfs-lzo-text-scanner.cc contained a buffer overrun when compiled in RELEASE mode. The underlying buffer overrun has been resolved, so Impala-lzo should now use whatever CMAKE_BUILD_TYPE that is used for Impala.

        Activity

        Hide
        joemcdonnell Joe McDonnell added a comment -

        commit ff5b0469b1a718d8e84976c9946752cfce0e357f
        Author: Joe McDonnell <joemcdonnell@cloudera.com>
        Date: Thu Apr 27 14:20:07 2017 -0700

        IMPALA-5258: Pass CMAKE_BUILD_TYPE to Impala-lzo

        Impala-lzo contained a buffer overrun that was only
        present when compiled in optimized mode. To avoid this
        (IMPALA-5172), Impala-lzo is only compiled in DEBUG mode.
        Since the underlying buffer overrun has been resolved,
        reenable passing the CMAKE_BUILD_TYPE down to Impala-lzo.

        Change-Id: I190d732a8244dd79bc422cc0c563fb09ba2ed561
        Reviewed-on: http://gerrit.cloudera.org:8080/6751
        Reviewed-by: Alex Behm <alex.behm@cloudera.com>
        Tested-by: Impala Public Jenkins

        Show
        joemcdonnell Joe McDonnell added a comment - commit ff5b0469b1a718d8e84976c9946752cfce0e357f Author: Joe McDonnell <joemcdonnell@cloudera.com> Date: Thu Apr 27 14:20:07 2017 -0700 IMPALA-5258 : Pass CMAKE_BUILD_TYPE to Impala-lzo Impala-lzo contained a buffer overrun that was only present when compiled in optimized mode. To avoid this ( IMPALA-5172 ), Impala-lzo is only compiled in DEBUG mode. Since the underlying buffer overrun has been resolved, reenable passing the CMAKE_BUILD_TYPE down to Impala-lzo. Change-Id: I190d732a8244dd79bc422cc0c563fb09ba2ed561 Reviewed-on: http://gerrit.cloudera.org:8080/6751 Reviewed-by: Alex Behm <alex.behm@cloudera.com> Tested-by: Impala Public Jenkins

          People

          • Assignee:
            joemcdonnell Joe McDonnell
            Reporter:
            joemcdonnell Joe McDonnell
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development