Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5222

Bits::Log2Ceiling eating 1% of CPU when running targeted-perf.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Impala 2.9.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Backend
    • Labels:
      None

      Description

      We reverted to using gutil's inefficient non-inlined version in some places with the gutil switch.

        Activity

        Hide
        tarmstrong Tim Armstrong added a comment -

        IMPALA-5222: don't call Bits::Log2*() functions

        Some of gutil's functions are fairly inefficient. We accidentally
        regressed this when switching to the new Bits::, and some of the
        BufferPool code that was in flight didn't switch over.

        This commit switches to calling BitUtil::Log2*() everywhere and makes
        sure that those functions are all implemented in an efficient way.

        Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c
        Reviewed-on: http://gerrit.cloudera.org:8080/6675
        Reviewed-by: Henry Robinson <henry@cloudera.com>
        Tested-by: Impala Public Jenkins

        Show
        tarmstrong Tim Armstrong added a comment - IMPALA-5222 : don't call Bits::Log2*() functions Some of gutil's functions are fairly inefficient. We accidentally regressed this when switching to the new Bits::, and some of the BufferPool code that was in flight didn't switch over. This commit switches to calling BitUtil::Log2*() everywhere and makes sure that those functions are all implemented in an efficient way. Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c Reviewed-on: http://gerrit.cloudera.org:8080/6675 Reviewed-by: Henry Robinson <henry@cloudera.com> Tested-by: Impala Public Jenkins

          People

          • Assignee:
            tarmstrong Tim Armstrong
            Reporter:
            tarmstrong Tim Armstrong
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development