Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5207

enable_distcc doesn't reset IMPALA_DISTCC_ENABLED

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Impala 2.9.0
    • Component/s: Infrastructure
    • Labels:
      None

      Activity

      Hide
      tarmstrong Tim Armstrong added a comment -

      IMPALA-5207,IMPALA-5214: distcc fixes

      enable_distcc should reset IMPALA_DISTCC_ENABLED, otherwise
      disable_distcc is not reversible.

      Remove the requirement of a toolchain at /opt/Impala-Toolchain. We can
      easily identify paths starting with $IMPALA_TOOLCHAIN and remap them in
      distcc.sh.

      Testing:
      Did a local build with distcc with IMPALA_TOOLCHAIN at a different
      location. Tried toggling disable_distcc and enable_distcc.

      Change-Id: Ic6456d0101cd15287c543cb576be6cd2391f1f26
      Reviewed-on: http://gerrit.cloudera.org:8080/6655
      Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
      Reviewed-by: Matthew Jacobs <mj@cloudera.com>
      Tested-by: Impala Public Jenkins

      Show
      tarmstrong Tim Armstrong added a comment - IMPALA-5207 , IMPALA-5214 : distcc fixes enable_distcc should reset IMPALA_DISTCC_ENABLED, otherwise disable_distcc is not reversible. Remove the requirement of a toolchain at /opt/Impala-Toolchain. We can easily identify paths starting with $IMPALA_TOOLCHAIN and remap them in distcc.sh. Testing: Did a local build with distcc with IMPALA_TOOLCHAIN at a different location. Tried toggling disable_distcc and enable_distcc. Change-Id: Ic6456d0101cd15287c543cb576be6cd2391f1f26 Reviewed-on: http://gerrit.cloudera.org:8080/6655 Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com> Reviewed-by: Matthew Jacobs <mj@cloudera.com> Tested-by: Impala Public Jenkins

        People

        • Assignee:
          tarmstrong Tim Armstrong
          Reporter:
          tarmstrong Tim Armstrong
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development