Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5187

Bump breakpad version to include the fix for Breakpad #681, re-enable the strict check that was disabled in IMPALA-3794

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Impala 2.9.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Infrastructure
    • Labels:

      Description

      IMPALA-3794 weakened an assertion to work around Breakpad #681. Once a fix has been merged into the Breakpad project, we need to bump our version and rework the check in test_breakpad.py to be more strict again.

        Issue Links

          Activity

          Hide
          lv Lars Volker added a comment -

          IMPALA-5187, IMPALA-5208: Bump Breakpad Version, undo IMPALA-3794

          This change switches to a new Breakpad version, which includes fixes for
          Breakpad bugs #681 and #728. The toolchain change was reviewed here:
          https://gerrit.cloudera.org/6866

          The change also undoes the workaround introduced in IMPALA-3794.

          In addition to running test_breakpad.py in a loop for a while, I tested
          Then I verified that the test fails with the old toolchain version
          (88e5b2) and works with the new one (ffe3e4).

          To test #728 I added a sleep() call before SendContinueSignalToChild()
          and then killed the parent process, manually observing that the child
          would die, too.

          Change-Id: Ic541ccd565f2bb51f68c085747fc47ae8c905d19
          Reviewed-on: http://gerrit.cloudera.org:8080/6883
          Reviewed-by: Lars Volker <lv@cloudera.com>
          Tested-by: Impala Public Jenkins

          Show
          lv Lars Volker added a comment - IMPALA-5187 , IMPALA-5208 : Bump Breakpad Version, undo IMPALA-3794 This change switches to a new Breakpad version, which includes fixes for Breakpad bugs #681 and #728. The toolchain change was reviewed here: https://gerrit.cloudera.org/6866 The change also undoes the workaround introduced in IMPALA-3794 . In addition to running test_breakpad.py in a loop for a while, I tested Then I verified that the test fails with the old toolchain version (88e5b2) and works with the new one (ffe3e4). To test #728 I added a sleep() call before SendContinueSignalToChild() and then killed the parent process, manually observing that the child would die, too. Change-Id: Ic541ccd565f2bb51f68c085747fc47ae8c905d19 Reviewed-on: http://gerrit.cloudera.org:8080/6883 Reviewed-by: Lars Volker <lv@cloudera.com> Tested-by: Impala Public Jenkins
          Hide
          lv Lars Volker added a comment -

          This issue is blocked by Breakpad #681

          Show
          lv Lars Volker added a comment - This issue is blocked by Breakpad #681

            People

            • Assignee:
              lv Lars Volker
              Reporter:
              lv Lars Volker
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development