Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5153

Refactor MemTracker::MemLimitExceeded() to avoid threading RuntimeState through everywhere.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • Impala 2.9.0
    • None
    • Backend
    • None
    • ghx-label-6

    Description

      Currently the method requires the caller to pass in the RuntimeState to properly log the error. In some places it isn't threaded through, so the memory limit error is not logged in the same way as it would be otherwise.

      We should instead store a pointer to the RuntimeState in the MemTracker so that this can be handled without requiring the caller to plumb it through.

      Attachments

        Issue Links

          depends upon

          Bug - A problem which impairs or prevents the functions of the product. IMPALA-4858 Provide better explanation for obscure Memory limit exceeded failures

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Activity

            People

              Unassigned Unassigned
              tarmstrong Tim Armstrong
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: