Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5027

udf headers are not longer buildable outside of Impala source tree

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Impala 2.8.0, Impala 2.9.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Backend
    • Labels:
      None

      Description

      Various headers in the udf subdirectory, including udf.h and the test harness should be compilable without C++11 and without the full Impala source checkout. They are used by impala-udf-samples to build and test custom UDFs.

      They're currently broken in a couple of ways:

      • noexcept is in udf.h
      • std::shared_ptr is used in a couple of places
      • runtime-state.h is included in one place
      • The "using underlying_type_t" logic depends on C++11 - I think

        Issue Links

          Activity

          Hide
          tarmstrong Tim Armstrong added a comment -

          IMPALA-5027: addendum - remove unneeded #define

          Change-Id: I8b460fc69ddb08ef0b68be725ec16782ab187806
          Reviewed-on: http://gerrit.cloudera.org:8080/6298
          Reviewed-by: Jim Apple <jbapple-impala@apache.org>
          Tested-by: Impala Public Jenkins

          M be/src/udf/udf.h
          1 file changed, 0 insertions, 1 deletion

          Approvals:
          Impala Public Jenkins: Verified
          Jim Apple: Looks good to me, approved

          Show
          tarmstrong Tim Armstrong added a comment - IMPALA-5027 : addendum - remove unneeded #define Change-Id: I8b460fc69ddb08ef0b68be725ec16782ab187806 Reviewed-on: http://gerrit.cloudera.org:8080/6298 Reviewed-by: Jim Apple <jbapple-impala@apache.org> Tested-by: Impala Public Jenkins — M be/src/udf/udf.h 1 file changed, 0 insertions , 1 deletion Approvals: Impala Public Jenkins: Verified Jim Apple: Looks good to me, approved
          Hide
          tarmstrong Tim Armstrong added a comment -

          IMPALA-5027: make udf headers buildable externally

          This fixes a number of issues that prevented building it:

          • Use of C++11 features
          • Use of internal headers that are only available in the Impala source
            tree

          Testing:
          Copied the headers and libImpalaUdf.a to /usr and confirmed I could
          build impala-udf-samples (with some modifications to udf-test-harness
          to use some modified arguments to the test harness).

          We really need a better solution for automatically testing this, e.g.
          IMPALA-5026, but I wanted to fix the known bugs first.

          Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e
          Reviewed-on: http://gerrit.cloudera.org:8080/6251
          Reviewed-by: Matthew Jacobs <mj@cloudera.com>
          Reviewed-by: Dan Hecht <dhecht@cloudera.com>
          Tested-by: Impala Public Jenkins

          Show
          tarmstrong Tim Armstrong added a comment - IMPALA-5027 : make udf headers buildable externally This fixes a number of issues that prevented building it: Use of C++11 features Use of internal headers that are only available in the Impala source tree Testing: Copied the headers and libImpalaUdf.a to /usr and confirmed I could build impala-udf-samples (with some modifications to udf-test-harness to use some modified arguments to the test harness). We really need a better solution for automatically testing this, e.g. IMPALA-5026 , but I wanted to fix the known bugs first. Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e Reviewed-on: http://gerrit.cloudera.org:8080/6251 Reviewed-by: Matthew Jacobs <mj@cloudera.com> Reviewed-by: Dan Hecht <dhecht@cloudera.com> Tested-by: Impala Public Jenkins

            People

            • Assignee:
              tarmstrong Tim Armstrong
              Reporter:
              tarmstrong Tim Armstrong
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development