[IMPALA-4998] Table.toThrift() called without holding the table lock: test_view_compatibility_b0595633.test_hive org.apache.impala.catalog

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: Impala 2.9.0
• Fix Version/s: Impala 2.9.0
• Component/s: Catalog
• Labels: broken-build
• Assignee: Alexander Behm
• Reporter: Michael Ho
• Created: 26/Feb/17 08:04
• Updated: 08/Dec/17 23:08
• Resolved: 02/Mar/17 15:26

Description

It appears that the commit https://github.com/apache/incubator-impala/commit/a71636847fe742a9d0eb770516aff34ff16bbca1 caused failure in test_view_compatibility. This may just be exposing pre-existing problem as there are callers of ToThrift() which didn't hold lock. alex.behm, would you mind taking a first look ?

Error Message

metadata/test_views_compatibility.py:74: in test_view_compatibility     unique_database) metadata/test_views_compatibility.py:138: in _run_view_compat_test_case     assert "TableNotFoundException" in str(e) E   assert 'TableNotFoundException' in "ImpalaBeeswaxException:\n INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: \nIllegalStateExcept...t() called without holding the table lock: test_view_compatibility_b0595633.test_hive org.apache.impala.catalog.View\n" E    +  where "ImpalaBeeswaxException:\n INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: \nIllegalStateExcept...t() called without holding the table lock: test_view_compatibility_b0595633.test_hive org.apache.impala.catalog.View\n" = str(ImpalaBeeswaxException())
Stacktrace

metadata/test_views_compatibility.py:74: in test_view_compatibility
    unique_database)
metadata/test_views_compatibility.py:138: in _run_view_compat_test_case
    assert "TableNotFoundException" in str(e)
E   assert 'TableNotFoundException' in "ImpalaBeeswaxException:\n INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: \nIllegalStateExcept...t() called without holding the table lock: test_view_compatibility_b0595633.test_hive org.apache.impala.catalog.View\n"
E    +  where "ImpalaBeeswaxException:\n INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: \nIllegalStateExcept...t() called without holding the table lock: test_view_compatibility_b0595633.test_hive org.apache.impala.catalog.View\n" = str(ImpalaBeeswaxException())

Issue Links

• is broken by: IMPALA-4902 Concurrent DDL may fail with a ConcurrentModificationException