Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4998

Table.toThrift() called without holding the table lock: test_view_compatibility_b0595633.test_hive org.apache.impala.catalog

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: Impala 2.9.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Catalog
    • Labels:

      Description

      It appears that the commit https://github.com/apache/incubator-impala/commit/a71636847fe742a9d0eb770516aff34ff16bbca1 caused failure in test_view_compatibility. This may just be exposing pre-existing problem as there are callers of ToThrift() which didn't hold lock. Alexander Behm, would you mind taking a first look ?

      Error Message
      
      metadata/test_views_compatibility.py:74: in test_view_compatibility     unique_database) metadata/test_views_compatibility.py:138: in _run_view_compat_test_case     assert "TableNotFoundException" in str(e) E   assert 'TableNotFoundException' in "ImpalaBeeswaxException:\n INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: \nIllegalStateExcept...t() called without holding the table lock: test_view_compatibility_b0595633.test_hive org.apache.impala.catalog.View\n" E    +  where "ImpalaBeeswaxException:\n INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: \nIllegalStateExcept...t() called without holding the table lock: test_view_compatibility_b0595633.test_hive org.apache.impala.catalog.View\n" = str(ImpalaBeeswaxException())
      Stacktrace
      
      metadata/test_views_compatibility.py:74: in test_view_compatibility
          unique_database)
      metadata/test_views_compatibility.py:138: in _run_view_compat_test_case
          assert "TableNotFoundException" in str(e)
      E   assert 'TableNotFoundException' in "ImpalaBeeswaxException:\n INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: \nIllegalStateExcept...t() called without holding the table lock: test_view_compatibility_b0595633.test_hive org.apache.impala.catalog.View\n"
      E    +  where "ImpalaBeeswaxException:\n INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: \nIllegalStateExcept...t() called without holding the table lock: test_view_compatibility_b0595633.test_hive org.apache.impala.catalog.View\n" = str(ImpalaBeeswaxException())
      

        Activity

        Hide
        alex.behm Alexander Behm added a comment -

        commit c46379602af3c007f9f8c98d8d52b8f7dec03270
        Author: Alex Behm <alex.behm@cloudera.com>
        Date: Mon Feb 27 21:42:26 2017 -0800

        IMPALA-4998: Fix missing table lock acquisition.

        The following commit broke test_views_compatibility.py
        which only runs in exhaustive mode, so the issue was
        not caught by pre-commit testing:
        a71636847fe742a9d0eb770516aff34ff16bbca1

        Testing: Before this patch test_views_compatibility.py
        failed locally reliably. After this patch the test
        passes locally.

        Change-Id: I0e0270daf59fce95f1a1520fc5aaf91d3a7b99fe
        Reviewed-on: http://gerrit.cloudera.org:8080/6177
        Reviewed-by: Alex Behm <alex.behm@cloudera.com>
        Tested-by: Impala Public Jenkins

        Show
        alex.behm Alexander Behm added a comment - commit c46379602af3c007f9f8c98d8d52b8f7dec03270 Author: Alex Behm <alex.behm@cloudera.com> Date: Mon Feb 27 21:42:26 2017 -0800 IMPALA-4998 : Fix missing table lock acquisition. The following commit broke test_views_compatibility.py which only runs in exhaustive mode, so the issue was not caught by pre-commit testing: a71636847fe742a9d0eb770516aff34ff16bbca1 Testing: Before this patch test_views_compatibility.py failed locally reliably. After this patch the test passes locally. Change-Id: I0e0270daf59fce95f1a1520fc5aaf91d3a7b99fe Reviewed-on: http://gerrit.cloudera.org:8080/6177 Reviewed-by: Alex Behm <alex.behm@cloudera.com> Tested-by: Impala Public Jenkins

          People

          • Assignee:
            alex.behm Alexander Behm
            Reporter:
            kwho Michael Ho
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development