[IMPALA-4990] run-tests.py --update_results doesn't work

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.8.0
• Fix Version/s: Impala 2.10.0
• Component/s: Infrastructure
• Target Version: Product Backlog
• Assignee: Daniel Hecht
• Reporter: Daniel Hecht
• Created: 24/Feb/17 23:03
• Updated: 23/Aug/17 18:03
• Resolved: 23/Aug/17 18:01

Description

Using run-tests.py --update_results gives this error:

query_test/test_queries.py:150: in test_strict_mode
    self.run_test_case('QueryTest/strict-mode', vector)
common/impala_test_suite.py:388: in run_test_case
    self.__verify_results_and_errors(vector, test_section, result, use_db)
common/impala_test_suite.py:273: in __verify_results_and_errors
    replace_filenames_with_placeholder)
common/test_result_verifier.py:407: in verify_raw_results
    test_section[results_section] = join_section_lines(actual.result_list)
E   NameError: global name 'results_section' is not defined

and then fixing that results in:

query_test/test_queries.py:153: in test_strict_mode
    self.run_test_case('QueryTest/strict-mode-abort', vector)
common/impala_test_suite.py:413: in run_test_case
    write_test_file(output_file, sections, encoding=encoding)
util/test_file_parser.py:298: in write_test_file
    test_file.write(('\n').join(test_file_text))
E   TypeError: sequence item 2: expected string, list found