Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4913

Toolchain broken on centos6/ubuntu12 after Kudu added boost

    Details

      Description

      When Kudu added boost to their thirdparty directory, the toolchain builds on centos5/ubuntu12 started failing. I believe it to be a compiler configuration issue but need to investigate further.

      17:35:56 g++: unrecognized option '-static-libstdc++'
      17:35:56 cc1plus: error: unrecognized command line option "-mno-avx2"
      17:35:56 ...failed updating 1 target...
      

        Activity

        Hide
        mjacobs Matthew Jacobs added a comment -

        Fixed by Kudu commit

        commit 3e659dcd914adfbdc544b083dfd1e0686b9018c4
        Author: Matthew Jacobs <mj@cloudera.com>
        Date: Mon Feb 13 14:33:06 2017 -0800

        KUDU-1870: Fix Boost build to respect CC/CXX

        Boost doesn't respect the CC/CXX environment variables, but
        they may have been set in the Kudu build environment. This
        fixes this issue by configuring Boost's compiler using the
        CC/CXX flags if they were set.

        Testing:

        • Ran thirdparty build locally, including for tsan. Checked
          that gcc/clang appeared to be set appropriately.
        • Ran Impala's toolchain build with this change, verifying
          the toolchain compiler in CC/CXX was used.

        Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
        Reviewed-on: http://gerrit.cloudera.org:8080/5986
        Reviewed-by: Adar Dembo <adar@cloudera.com>
        Tested-by: Kudu Jenkins
        Reviewed-by: Todd Lipcon <todd@apache.org>

        Show
        mjacobs Matthew Jacobs added a comment - Fixed by Kudu commit commit 3e659dcd914adfbdc544b083dfd1e0686b9018c4 Author: Matthew Jacobs <mj@cloudera.com> Date: Mon Feb 13 14:33:06 2017 -0800 KUDU-1870 : Fix Boost build to respect CC/CXX Boost doesn't respect the CC/CXX environment variables, but they may have been set in the Kudu build environment. This fixes this issue by configuring Boost's compiler using the CC/CXX flags if they were set. Testing: Ran thirdparty build locally, including for tsan. Checked that gcc/clang appeared to be set appropriately. Ran Impala's toolchain build with this change, verifying the toolchain compiler in CC/CXX was used. Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522 Reviewed-on: http://gerrit.cloudera.org:8080/5986 Reviewed-by: Adar Dembo <adar@cloudera.com> Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <todd@apache.org>

          People

          • Assignee:
            mjacobs Matthew Jacobs
            Reporter:
            mjacobs Matthew Jacobs
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development