Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4904

test_ddl_stress isn't runnable through buildall.sh entry point

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Impala 2.9.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Infrastructure
    • Labels:
      None

      Description

      This is a particular manifestation of IMPALA-3947. test_ddl_stress assigns its workload as "targeted-stress", which makes it not subject to buildall.sh "exhaustive" tests, which only apply to the workload "functional-query". This means any environment or commandline options to "run exhaustive tests" still won't cause test_ddl_stress.py to run.

      This is a problem if people assumed test_ddl_stress.py had been running via buildall.sh this entire time. It's less of a problem if this is a known thing and people are very self-conscious about running test_ddl_stress.py locally.

        Activity

        Hide
        mikesbrown Michael Brown added a comment -

        I reached out to the list to know if anyone has any history about this. I think that could help lend context to what's going on. Maybe this was an honest oversight, or maybe not.

        Show
        mikesbrown Michael Brown added a comment - I reached out to the list to know if anyone has any history about this. I think that could help lend context to what's going on. Maybe this was an honest oversight, or maybe not.
        Hide
        mikesbrown Michael Brown added a comment -

        The answer on the mailing list is that it was assumed this test was running. https://gerrit.cloudera.org/#/c/6002/ reenables it.

        Show
        mikesbrown Michael Brown added a comment - The answer on the mailing list is that it was assumed this test was running. https://gerrit.cloudera.org/#/c/6002/ reenables it.
        Hide
        mikesbrown Michael Brown added a comment -
        commit 9414d53a891448be13228f5fc63e089522e143aa
        Author: Michael Brown <mikeb@cloudera.com>
        Date:   Fri Feb 10 09:35:16 2017 -0800
        
            IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests
        
            This patch allows any test suites whose workload is "targeted-stress" to
            be run in so-called "exhaustive" mode. Before this patch, only suites
            whose workload was "functional-query" would be run exhaustively. More on
            this flaw is in IMPALA-3947.
        
            The net effects are:
        
            1. We fix IMPALA-4904, which allows test_ddl_stress to start running
               again.
            2. We also improve the situation in IMPALA-4914 by getting
               TestSpillStress to run, though we don't fix its
               not-running-concurrently problem.
        
            The other mini-cluster stress tests were disabled in this commit:
              IMPALA-2605: Omit the sort and mini stress tests
            so they are not directly affected here.
        
            I also tried to clarify what "exhaustive" means in some of our shell
            scripts, via help text and comments.
        
            An exhaustive build+test run showed test_ddl_stress and TestSpillStress
            now get run and passed. This adds roughly 12 minutes to a build that's
            on the order of 13-14 hours.
        
            Change-Id: Ie6bd5bbd380e636d680368e908519b042d79dfec
            Reviewed-on: http://gerrit.cloudera.org:8080/6002
            Tested-by: Impala Public Jenkins
            Reviewed-by: Jim Apple <jbapple-impala@apache.org>
        
        Show
        mikesbrown Michael Brown added a comment - commit 9414d53a891448be13228f5fc63e089522e143aa Author: Michael Brown <mikeb@cloudera.com> Date: Fri Feb 10 09:35:16 2017 -0800 IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests This patch allows any test suites whose workload is "targeted-stress" to be run in so-called "exhaustive" mode. Before this patch, only suites whose workload was "functional-query" would be run exhaustively. More on this flaw is in IMPALA-3947. The net effects are: 1. We fix IMPALA-4904, which allows test_ddl_stress to start running again. 2. We also improve the situation in IMPALA-4914 by getting TestSpillStress to run, though we don't fix its not-running-concurrently problem. The other mini-cluster stress tests were disabled in this commit: IMPALA-2605: Omit the sort and mini stress tests so they are not directly affected here. I also tried to clarify what "exhaustive" means in some of our shell scripts, via help text and comments. An exhaustive build+test run showed test_ddl_stress and TestSpillStress now get run and passed. This adds roughly 12 minutes to a build that's on the order of 13-14 hours. Change-Id: Ie6bd5bbd380e636d680368e908519b042d79dfec Reviewed-on: http://gerrit.cloudera.org:8080/6002 Tested-by: Impala Public Jenkins Reviewed-by: Jim Apple <jbapple-impala@apache.org>

          People

          • Assignee:
            mikesbrown Michael Brown
            Reporter:
            mikesbrown Michael Brown
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development