Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4873

run_test_case() should find/replace arbitrary strings in /testdata/workloads/*/queries/*.test

    Details

      Description

      E.g. this test in query_test/test_kudu.py...

      @pytest.mark.execute_serially
      def test_kudu_alter_table(self, vector, unique_database):
          self.run_test_case('QueryTest/kudu_alter', vector, use_db=unique_database)
      

      ...contains hardcoded values for kudu.master_addresses:

      ====
      ---- QUERY
      # Alter master address to a different location
      alter table simple set tblproperties (
        'kudu.master_addresses' = 'localhost'
      )
      ---- RESULTS
      'Updated table.'
      ---- TYPES
      STRING
      ====
      ---- QUERY
      # Show that new address is picked up
      describe formatted simple
      ---- RESULTS: VERIFY_IS_SUBSET
      '','kudu.master_addresses','localhost           '
      ---- TYPES
      STRING,STRING,STRING
      ====
      ---- QUERY
      alter table simple set tblproperties ('kudu.master_addresses' = '127.0.0.1')
      ---- RESULTS
      'Updated table.'
      ---- TYPES
      STRING
      

      There's no way currently to make this test run on remote clusters because there's no way to replace the hardcoded values.

        Attachments

          Activity

            People

            • Assignee:
              lv Lars Volker
              Reporter:
              dknupp David Knupp
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: