Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Impala 2.8.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Backend
    • Labels:
      None

      Description

      For IMPALA-2020 and other decimal related changes, we'll want a way to eliminate runtime overhead of query options on the decimal evaluation paths. Let's add a way to insert codegen constants from query option values.

        Activity

        Hide
        zamsden_impala_ad21 Zachary added a comment -

        If it's okay, I'd like to start working on this.

        Show
        zamsden_impala_ad21 Zachary added a comment - If it's okay, I'd like to start working on this.
        Hide
        kwho Michael Ho added a comment -

        https://github.com/apache/incubator-impala/commit/f982c3f76e762f646b52a01659796b4edcfbc1ad

        IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2
        Currently, codegen supports converting type attributes (e.g.
        decimal type's precision and scale, type's size) obtained via
        calls to FunctionContextImpl::GetFnAttr() (previously
        Expr::GetConstantInt()) in cross-compiled code to runtime constants.
        This change extends this support for the query option DECIMAL_V2.

        To test this change, this change also handles a subset of IMPALA-2020:
        casting between decimal values is updated to support rounding (instead
        of truncation) when decimal_v2 is true.

        This change also cleans up the existing code by moving the codegen
        logic Expr::InlineConstant() to the codegen module and the type
        related logic in Expr::GetConstantInt() to FunctionContextImpl.

        Change-Id: I2434d240f65b81389b8a8ba027f980a0e1d1f981
        Reviewed-on: http://gerrit.cloudera.org:8080/5950
        Reviewed-by: Michael Ho <kwho@cloudera.com>
        Tested-by: Impala Public Jenkins

        Show
        kwho Michael Ho added a comment - https://github.com/apache/incubator-impala/commit/f982c3f76e762f646b52a01659796b4edcfbc1ad IMPALA-2020 , IMPALA-4809 : Codegen support for DECIMAL_V2 Currently, codegen supports converting type attributes (e.g. decimal type's precision and scale, type's size) obtained via calls to FunctionContextImpl::GetFnAttr() (previously Expr::GetConstantInt()) in cross-compiled code to runtime constants. This change extends this support for the query option DECIMAL_V2. To test this change, this change also handles a subset of IMPALA-2020 : casting between decimal values is updated to support rounding (instead of truncation) when decimal_v2 is true. This change also cleans up the existing code by moving the codegen logic Expr::InlineConstant() to the codegen module and the type related logic in Expr::GetConstantInt() to FunctionContextImpl. Change-Id: I2434d240f65b81389b8a8ba027f980a0e1d1f981 Reviewed-on: http://gerrit.cloudera.org:8080/5950 Reviewed-by: Michael Ho <kwho@cloudera.com> Tested-by: Impala Public Jenkins

          People

          • Assignee:
            kwho Michael Ho
            Reporter:
            dhecht Dan Hecht
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development