[IMPALA-4757] Macros in testutil/gtest-util.h evaluate their arguments twice

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.8.0
• Fix Version/s: Impala 2.9.0
• Component/s: Infrastructure
• Target Version: Product Backlog
• Assignee: Tim Armstrong
• Reporter: Tim Armstrong
• Created: 11/Jan/17 23:00
• Updated: 13/Jan/17 16:29
• Resolved: 12/Jan/17 16:59

Description

I just discovered that the macros are written such that they evaluate their arguments twice. This can have confusing consequences if the argument is a function with side-effects.