Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4710

There is an error in control audit log file size number

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Impala 2.5.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Backend
    • Labels:
      None

      Description

      There is an error in control audit log file size number. When I set max_audit_event_log_file_size of impalad to N, the max size of audit event log file is N+1 which is larger than the former actually.

        Activity

        Hide
        davidxdh Donghui Xu added a comment -

        OK. I didn't find my patch in the link you provided. I have changed the Fix Version to 2.9.0.

        Show
        davidxdh Donghui Xu added a comment - OK. I didn't find my patch in the link you provided. I have changed the Fix Version to 2.9.0.
        Hide
        jbapple Jim Apple added a comment -

        This is a bulk comment on all issues with Fix Version 2.8.0 that were resolved on or after 2016-12-09.

        2.8.0 was branched on December 9, with only two changes to master cherry-picked to the 2.8.0 release branch after that:

        https://github.com/apache/incubator-impala/commits/2.8.0

        Issues fixed after December 9 might not be fixed in 2.8.0. If you are the one who marked this issue Resolved, can you check to see if the patch is in 2.8.0 by using the link above? If the patch is not in 2.8.0, can you change the Fix Version to 2.9.0?

        Thank you!

        Show
        jbapple Jim Apple added a comment - This is a bulk comment on all issues with Fix Version 2.8.0 that were resolved on or after 2016-12-09. 2.8.0 was branched on December 9, with only two changes to master cherry-picked to the 2.8.0 release branch after that: https://github.com/apache/incubator-impala/commits/2.8.0 Issues fixed after December 9 might not be fixed in 2.8.0. If you are the one who marked this issue Resolved, can you check to see if the patch is in 2.8.0 by using the link above? If the patch is not in 2.8.0, can you change the Fix Version to 2.9.0? Thank you!
        Hide
        davidxdh Donghui Xu added a comment -

        IMPALA-4710: There is an error in control audit log file size number

        The comparison logic of log file size and maximum config is wrong,
        leading to log file size is greater than the maximum config.

        This patch corrects the error, makes both are consistent.

        Change-Id: I1808d69359102d63b732469b440c9c7675a371b7
        Reviewed-on: http://gerrit.cloudera.org:8080/5582
        Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
        Tested-by: Impala Public Jenkins

        Show
        davidxdh Donghui Xu added a comment - IMPALA-4710 : There is an error in control audit log file size number The comparison logic of log file size and maximum config is wrong, leading to log file size is greater than the maximum config. This patch corrects the error, makes both are consistent. Change-Id: I1808d69359102d63b732469b440c9c7675a371b7 Reviewed-on: http://gerrit.cloudera.org:8080/5582 Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com> Tested-by: Impala Public Jenkins

          People

          • Assignee:
            davidxdh Donghui Xu
            Reporter:
            davidxdh Donghui Xu
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development