Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4697

RuntimeState::LogError() does not log merged status

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: Impala 2.8.0
    • Fix Version/s: None
    • Component/s: Backend
    • Labels:

      Description

      If MergeStatus() or AddDetail() is called on the status, and then that Status is passed to RuntimeState::LogError(), the merged error messages are silently dropped and never reported anywhere.

      We should fix this because the merged error messages often include important diagnostic info.

      See

       
      VLOG(vlog_level) << "Error from query " << PrintId(query_id()) << ": " << message.msg();
      
       
      void AppendError(ErrorLogMap* map, const ErrorMsg& e) {
        ErrorLogEntryPB* target = &(*map)[e.error()];
        if (e.error() == TErrorCode::GENERAL) {
          target->add_messages(e.msg());
        } else {
          if (target->messages_size() == 0) {
            target->add_messages(e.msg());
          }
          target->set_count(target->count() + 1);
        }
      }
      

      The issue is that .msg() is the original error string and does not include the additional details.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                tarmstrong Tim Armstrong
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: