Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: Impala 2.7.0
-
Fix Version/s: Impala 2.9.0
-
Component/s: Backend
-
Labels:None
Description
The last active time in impala-server.cc#L1806 is in milliseconds, but the TimestampValue c'tor expects seconds.
VLOG_QUERY << "Expiring query due to client inactivity: "
<< expiration_event->second << ", last activity was at: "
<< TimestampValue(query_state->last_active()).DebugString();
const string& err_msg = Substitute(
"Query $0 expired due to client inactivity (timeout is $1)",
PrintId(expiration_event->second),
PrettyPrinter::Print(timeout_s * 1000000000L, TUnit::TIME_NS));
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
IMPALA-4689: Fix computation of last active timeThe last active time in impala-server.cc#L1806 is in milliseconds, but
the TimestampValue c'tor expects seconds. This change also renames some
variables to make their meaning more explicit, aiming to prevent similar
bugs in the future.
This change also fixes a bug that occurred when during startup of the
local minicluster the operating system PIDs would wrap around. This way
the first impalad would not be the one with the smallest PID and
ImpalaCluster.get_first_impalad() would return the wrong one.
I ran git-clang-format on the change.
Change-Id: I283564c8d8e145d44d9493f4201555d3a1087edf
Reviewed-on: http://gerrit.cloudera.org:8080/5546
Reviewed-by: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Reviewed-by: Marcel Kornacker <marcel@cloudera.com>
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Internal Jenkins