Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4649

Add a mechanism to pass flags into make

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Impala 2.9.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Infrastructure
    • Labels:
      None

      Description

      We should add a mechanism for build scripts to pass flags into make.

      For example Philip Zeyliger was telling me offline about some experiments he did with passing --load-avg to make. It allowed him to build Impala in parallel with other processes without blowing up memory consumption. There's currently no way to do this aside from hacking build scripts.

        Activity

        Hide
        jbapple Jim Apple added a comment -

        This is a bulk comment on all issues with Fix Version 2.8.0 that were resolved on or after 2016-12-09.

        2.8.0 was branched on December 9, with only two changes to master cherry-picked to the 2.8.0 release branch after that:

        https://github.com/apache/incubator-impala/commits/2.8.0

        Issues fixed after December 9 might not be fixed in 2.8.0. If you are the one who marked this issue Resolved, can you check to see if the patch is in 2.8.0 by using the link above? If the patch is not in 2.8.0, can you change the Fix Version to 2.9.0?

        Thank you!

        Show
        jbapple Jim Apple added a comment - This is a bulk comment on all issues with Fix Version 2.8.0 that were resolved on or after 2016-12-09. 2.8.0 was branched on December 9, with only two changes to master cherry-picked to the 2.8.0 release branch after that: https://github.com/apache/incubator-impala/commits/2.8.0 Issues fixed after December 9 might not be fixed in 2.8.0. If you are the one who marked this issue Resolved, can you check to see if the patch is in 2.8.0 by using the link above? If the patch is not in 2.8.0, can you change the Fix Version to 2.9.0? Thank you!
        Hide
        tarmstrong Tim Armstrong added a comment -

        IMPALA-4649: addendum - avoid overwriting MAKE_ARGS

        Re-tested to make sure that IMPALA_MAKE_FLAGS is effective

        Change-Id: If57dc60e16bab591bce3646d43de8d45444719a7
        Reviewed-on: http://gerrit.cloudera.org:8080/5558
        Tested-by: Impala Public Jenkins
        Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
        Tested-by: Tim Armstrong <tarmstrong@cloudera.com>

        M bin/make_impala.sh
        1 file changed, 0 insertions, 1 deletion

        Show
        tarmstrong Tim Armstrong added a comment - IMPALA-4649 : addendum - avoid overwriting MAKE_ARGS Re-tested to make sure that IMPALA_MAKE_FLAGS is effective Change-Id: If57dc60e16bab591bce3646d43de8d45444719a7 Reviewed-on: http://gerrit.cloudera.org:8080/5558 Tested-by: Impala Public Jenkins Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com> Tested-by: Tim Armstrong <tarmstrong@cloudera.com> — M bin/make_impala.sh 1 file changed, 0 insertions , 1 deletion
        Hide
        tarmstrong Tim Armstrong added a comment -

        I introduced a bug when rebasing that prevents this from being effective.

        Show
        tarmstrong Tim Armstrong added a comment - I introduced a bug when rebasing that prevents this from being effective.
        Hide
        tarmstrong Tim Armstrong added a comment -

        IMPALA-4649: add a mechanism to pass flags into make

        Testing:
        Tested that buildall.sh works as expected. Built locally with
        IMPALA_MAKE_FLAGS unset to confirm I didn't break anything.

        Built locally with
        IMPALA_MAKE_FLAGS=--load-average=$IMPALA_BUILD_THREADS and looked
        at "ps auxf" output to confirm it's passed through.

        Change-Id: I17b13cbaf395f962762d5cff3d650ffb077934a4
        Reviewed-on: http://gerrit.cloudera.org:8080/5480
        Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
        Tested-by: Impala Public Jenkins

        Show
        tarmstrong Tim Armstrong added a comment - IMPALA-4649 : add a mechanism to pass flags into make Testing: Tested that buildall.sh works as expected. Built locally with IMPALA_MAKE_FLAGS unset to confirm I didn't break anything. Built locally with IMPALA_MAKE_FLAGS=--load-average=$IMPALA_BUILD_THREADS and looked at "ps auxf" output to confirm it's passed through. Change-Id: I17b13cbaf395f962762d5cff3d650ffb077934a4 Reviewed-on: http://gerrit.cloudera.org:8080/5480 Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com> Tested-by: Impala Public Jenkins —

          People

          • Assignee:
            tarmstrong Tim Armstrong
            Reporter:
            tarmstrong Tim Armstrong
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development