Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4630

Remove suspicious (but harmless) base64-encoded javascript in common-footer.tmpl

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Impala 2.8.0
    • Fix Version/s: Impala 2.8.0
    • Component/s: Distributed Exec
    • Labels:
      None

      Description

      common-foot.tmpl has a harmless easter egg as base64-encoded javascript. We should make the code look less suspicious. We should also remove the reference to an external URL.

        Activity

        Hide
        henryr Henry Robinson added a comment -

        Can we just remove it entirely? I don't think it serves any purpose.

        Show
        henryr Henry Robinson added a comment - Can we just remove it entirely? I don't think it serves any purpose.
        Hide
        tarmstrong Tim Armstrong added a comment -

        I don't feel strongly, seems like a fun easter egg aside from it looking shady.

        Show
        tarmstrong Tim Armstrong added a comment - I don't feel strongly, seems like a fun easter egg aside from it looking shady.
        Hide
        tarmstrong Tim Armstrong added a comment -

        Missed resolving this earlier:
        commit 1a558be5f5e34df1024026f69fe1f17a72a72d99
        Author: Tim Armstrong <tarmstrong@cloudera.com>
        Date: Thu Dec 8 14:20:34 2016 -0800

        IMPALA-4630: remove debug webpage easter egg

        Change-Id: Ic2b1eb876dcec71a56bf76ea5f045818c6cd9a78
        Reviewed-on: http://gerrit.cloudera.org:8080/5429
        Tested-by: Impala Public Jenkins
        Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>

        Show
        tarmstrong Tim Armstrong added a comment - Missed resolving this earlier: commit 1a558be5f5e34df1024026f69fe1f17a72a72d99 Author: Tim Armstrong <tarmstrong@cloudera.com> Date: Thu Dec 8 14:20:34 2016 -0800 IMPALA-4630 : remove debug webpage easter egg Change-Id: Ic2b1eb876dcec71a56bf76ea5f045818c6cd9a78 Reviewed-on: http://gerrit.cloudera.org:8080/5429 Tested-by: Impala Public Jenkins Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
        Hide
        jbapple Jim Apple added a comment -

        This is a bulk comment on all issues with Fix Version 2.8.0 that were resolved on or after 2016-12-09.

        2.8.0 was branched on December 9, with only two changes to master cherry-picked to the 2.8.0 release branch after that:

        https://github.com/apache/incubator-impala/commits/2.8.0

        Issues fixed after December 9 might not be fixed in 2.8.0. If you are the one who marked this issue Resolved, can you check to see if the patch is in 2.8.0 by using the link above? If the patch is not in 2.8.0, can you change the Fix Version to 2.9.0?

        Thank you!

        Show
        jbapple Jim Apple added a comment - This is a bulk comment on all issues with Fix Version 2.8.0 that were resolved on or after 2016-12-09. 2.8.0 was branched on December 9, with only two changes to master cherry-picked to the 2.8.0 release branch after that: https://github.com/apache/incubator-impala/commits/2.8.0 Issues fixed after December 9 might not be fixed in 2.8.0. If you are the one who marked this issue Resolved, can you check to see if the patch is in 2.8.0 by using the link above? If the patch is not in 2.8.0, can you change the Fix Version to 2.9.0? Thank you!

          People

          • Assignee:
            tarmstrong Tim Armstrong
            Reporter:
            tarmstrong Tim Armstrong
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development