[IMPALA-4620] The eval cost of exprs should always be set in in analyze(), even if the eval cost is unknown (-1).

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.7.0
• Fix Version/s: Impala 2.11.0
• Component/s: Frontend
• Labels: newbie performance
• Target Version: Product Backlog
• Assignee: Tianyi Wang
• Reporter: Alexander Behm
• Created: 07/Dec/16 23:47
• Updated: 07/Sep/17 17:05
• Resolved: 07/Sep/17 17:05

Description

The eval cost of an Expr should always be set in analyze(), even if the eval cost is unknown (-1).

The following sequence of events will make an Expr have an incorrect eval cost set:
1. analyze() Expr e which sets a valid eval cost
2. substitute a child of e with an expr that has an invalid eval cost
3. calling analyze() on e will leave the original valid eval cost, but it should be invalid after the substitution+analyze