Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4540

Scheduler calls function in DCHECK, leading to crash

    Details

      Description

      The fix for IMPALA-4494 wrapped the call to backend_config_.LookUpBackendIp in simple-scheduler.cc:922 in a DCHECK, effectively disabling it in release builds. This leads to a crash when backend_ip is empty.

      921   IpAddr backend_ip;
      922   DCHECK(backend_config_.LookUpBackendIp(backend.address.hostname, &backend_ip));
      923   DCHECK(!backend_ip.empty());
      924   assignment_heap_.InsertOrUpdate(backend_ip, scan_range_length,
      925       GetBackendRank(backend_ip));
      

        Issue Links

          Activity

          Hide
          lv Lars Volker added a comment -

          I pushed a fix to here: https://gerrit.cloudera.org/#/c/5218/

          Show
          lv Lars Volker added a comment - I pushed a fix to here: https://gerrit.cloudera.org/#/c/5218/
          Hide
          lv Lars Volker added a comment -

          IMPALA-4540: Function call in DCHECK crashes scheduler

          The fix for IMPALA-4494 wrapped the call to
          backend_config_.LookUpBackendIp in simple-scheduler.cc:922 in a DCHECK,
          effectively disabling it in release builds. This leads to a crash when
          backend_ip is empty.

          This change makes sure that the function is always called.

          Change-Id: Iefbf719e86a59c09c45a5418f6ec0aa5cc4d8c44
          Reviewed-on: http://gerrit.cloudera.org:8080/5218
          Reviewed-by: Michael Ho <kwho@cloudera.com>
          Tested-by: Internal Jenkins

          Show
          lv Lars Volker added a comment - IMPALA-4540 : Function call in DCHECK crashes scheduler The fix for IMPALA-4494 wrapped the call to backend_config_.LookUpBackendIp in simple-scheduler.cc:922 in a DCHECK, effectively disabling it in release builds. This leads to a crash when backend_ip is empty. This change makes sure that the function is always called. Change-Id: Iefbf719e86a59c09c45a5418f6ec0aa5cc4d8c44 Reviewed-on: http://gerrit.cloudera.org:8080/5218 Reviewed-by: Michael Ho <kwho@cloudera.com> Tested-by: Internal Jenkins

            People

            • Assignee:
              lv Lars Volker
              Reporter:
              lv Lars Volker
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development