[IMPALA-4450] random query generator: prefer || for postgres string concatenation

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.8.0
• Fix Version/s: Impala 2.8.0
• Component/s: Infrastructure
• Labels: query_generator
• Target Version: Impala 2.8.0
• Assignee: Michael Brown
• Reporter: Michael Brown
• Created: 09/Nov/16 15:09
• Updated: 30/Nov/16 16:28
• Resolved: 30/Nov/16 16:28

Description

If Impala CONCAT() has an argument that evaluates to NULL, then Impala
CONCAT() returns NULL.

If PostgreSQL CONCAT() has an argument that evaluates to NULL, then
PostgreSQL will ignore it, and treat it as an empty string. Even
CONCAT(NULL) evaluates to the empty string.

PostgreSQL has a || operator that behaves like Impala CONCAT(): if a
NULL expression is on one side of ||, that || evals to NULL

For the Postgres SQL writer, we need to write logical concatenation as the || operator, not the CONCAT() function.