Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4441

Divide-by-zero in RuntimeProfile::SummaryStatsCounter::SetStats

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: Impala 2.8.0
    • Fix Version/s: Impala 2.8.0
    • Component/s: Backend
    • Labels:

      Description

      counter.total_num_values is 0 in the following code:

      void RuntimeProfile::SummaryStatsCounter::SetStats(const TSummaryStatsCounter& counter) {
        lock_guard<SpinLock> l(lock_);
        unit_ = counter.unit;
        sum_ = counter.sum;
        total_num_values_ = counter.total_num_values;
        min_ = counter.min_value;
        max_ = counter.max_value;
      
        value_.Store(sum_ / total_num_values_);
      }
      
      #0  0x0000003bb7e328e5 in raise () from /lib64/libc.so.6
      #1  0x0000003bb7e340c5 in abort () from /lib64/libc.so.6
      #2  0x00007f169c39ec55 in os::abort(bool) () from /opt/toolchain/sun-jdk-64bit-1.7.0.75/jre/lib/amd64/server/libjvm.so
      #3  0x00007f169c520cd7 in VMError::report_and_die() () from /opt/toolchain/sun-jdk-64bit-1.7.0.75/jre/lib/amd64/server/libjvm.so
      #4  0x00007f169c3a3b6f in JVM_handle_linux_signal () from /opt/toolchain/sun-jdk-64bit-1.7.0.75/jre/lib/amd64/server/libjvm.so
      #5  <signal handler called>
      #6  0x00000000015b469d in impala::RuntimeProfile::SummaryStatsCounter::SetStats (this=0x9aa55c0, counter=...) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/repos/Impala/be/src/util/runtime-profile.cc:1047
      #7  0x00000000015addc6 in impala::RuntimeProfile::Update (this=0x16fb8a80, nodes=..., idx=0x7f15d3dbfabc) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/repos/Impala/be/src/util/runtime-profile.cc:307
      #8  0x00000000015adfdf in impala::RuntimeProfile::Update (this=0xb41fb80, nodes=..., idx=0x7f15d3dbfabc) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/repos/Impala/be/src/util/runtime-profile.cc:328
      #9  0x00000000015ad342 in impala::RuntimeProfile::Update (this=0xb41fb80, thrift_profile=...) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/repos/Impala/be/src/util/runtime-profile.cc:224
      #10 0x000000000198c3e6 in impala::Coordinator::UpdateFragmentExecStatus (this=0x10e3f200, params=...) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/repos/Impala/be/src/runtime/coordinator.cc:1454
      #11 0x0000000001467961 in impala::ImpalaServer::ReportExecStatus (this=0x855d200, return_val=..., params=...) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/repos/Impala/be/src/service/impala-server.cc:1093
      #12 0x0000000001476f81 in impala::ImpalaInternalService::ReportExecStatus (this=0x8dd9120, return_val=..., params=...) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/repos/Impala/be/src/service/impala-internal-service.h:55
      #13 0x00000000018fc9a4 in impala::ImpalaInternalServiceProcessor::process_ReportExecStatus (this=0x8487480, seqid=0, iprot=0x8f89110, oprot=0x8f89140, callContext=0x8f8b040) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/repos/Impala/be/generated-sources/gen-cpp/ImpalaInternalService.cpp:1451
      #14 0x00000000018fbf8a in impala::ImpalaInternalServiceProcessor::dispatchCall (this=0x8487480, iprot=0x8f89110, oprot=0x8f89140, fname=..., seqid=0, callContext=0x8f8b040) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/repos/Impala/be/generated-sources/gen-cpp/ImpalaInternalService.cpp:1370
      #15 0x000000000115ac9c in apache::thrift::TDispatchProcessor::process (this=0x8487480, in=..., out=..., connectionContext=0x8f8b040) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/Impala-Toolchain/thrift-0.9.0-p8/include/thrift/TDispatchProcessor.h:121
      #16 0x0000000001322869 in apache::thrift::server::TAcceptQueueServer::Task::run (this=0x8efbb00) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/repos/Impala/be/src/rpc/TAcceptQueueServer.cpp:76
      #17 0x000000000131e947 in impala::ThriftThread::RunRunnable (this=0x8f8a1c0, runnable=..., promise=0x7f16482b6460) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/repos/Impala/be/src/rpc/thrift-thread.cc:64
      #18 0x0000000001320073 in boost::_mfi::mf2<void, impala::ThriftThread, boost::shared_ptr<apache::thrift::concurrency::Runnable>, impala::Promise<unsigned long>*>::operator() (this=0x7fb83c0, p=0x8f8a1c0, a1=..., a2=0x7f16482b6460) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/Impala-Toolchain/boost-1.57.0/include/boost/bind/mem_fn_template.hpp:280
      #19 0x000000000131ff09 in boost::_bi::list3<boost::_bi::value<impala::ThriftThread*>, boost::_bi::value<boost::shared_ptr<apache::thrift::concurrency::Runnable> >, boost::_bi::value<impala::Promise<unsigned long>*> >::operator()<boost::_mfi::mf2<void, impala::ThriftThread, boost::shared_ptr<apache::thrift::concurrency::Runnable>, impala::Promise<unsigned long>*>, boost::_bi::list0> (this=0x7fb83d0, f=..., a=...) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/Impala-Toolchain/boost-1.57.0/include/boost/bind/bind.hpp:392
      #20 0x000000000131fc55 in boost::_bi::bind_t<void, boost::_mfi::mf2<void, impala::ThriftThread, boost::shared_ptr<apache::thrift::concurrency::Runnable>, impala::Promise<unsigned long>*>, boost::_bi::list3<boost::_bi::value<impala::ThriftThread*>, boost::_bi::value<boost::shared_ptr<apache::thrift::concurrency::Runnable> >, boost::_bi::value<impala::Promise<unsigned long>*> > >::operator() (this=0x7fb83c0) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/Impala-Toolchain/boost-1.57.0/include/boost/bind/bind_template.hpp:20
      #21 0x000000000131fb68 in boost::detail::function::void_function_obj_invoker0<boost::_bi::bind_t<void, boost::_mfi::mf2<void, impala::ThriftThread, boost::shared_ptr<apache::thrift::concurrency::Runnable>, impala::Promise<unsigned long>*>, boost::_bi::list3<boost::_bi::value<impala::ThriftThread*>, boost::_bi::value<boost::shared_ptr<apache::thrift::concurrency::Runnable> >, boost::_bi::value<impala::Promise<unsigned long>*> > >, void>::invoke (function_obj_ptr=...) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/Impala-Toolchain/boost-1.57.0/include/boost/function/function_template.hpp:153
      #22 0x000000000132d4d4 in boost::function0<void>::operator() (this=0x7f15d3dc0c40) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/Impala-Toolchain/boost-1.57.0/include/boost/function/function_template.hpp:767
      #23 0x00000000015d6253 in impala::Thread::SuperviseThread (name=..., category=..., functor=..., thread_started=0x7f16482b6250) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/repos/Impala/be/src/util/thread.cc:317
      #24 0x00000000015dd22c in boost::_bi::list4<boost::_bi::value<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, boost::_bi::value<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, boost::_bi::value<boost::function<void()> >, boost::_bi::value<impala::Promise<long int>*> >::operator()<void (*)(const std::basic_string<char>&, const std::basic_string<char>&, boost::function<void()>, impala::Promise<long int>*), boost::_bi::list0>(boost::_bi::type<void>, void (*&)(const std::basic_string<char, std::char_traits<char>, std::allocator<char> > &, const std::basic_string<char, std::char_traits<char>, std::allocator<char> > &, boost::function<void()>, impala::Promise<long> *), boost::_bi::list0 &, int) (this=0x7c329c0, f=@0x7c329b8, a=...) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/Impala-Toolchain/boost-1.57.0/include/boost/bind/bind.hpp:457
      #25 0x00000000015dd16f in boost::_bi::bind_t<void, void (*)(const std::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const std::basic_string<char, std::char_traits<char>, std::allocator<char> >&, boost::function<void()>, impala::Promise<long int>*), boost::_bi::list4<boost::_bi::value<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, boost::_bi::value<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, boost::_bi::value<boost::function<void()> >, boost::_bi::value<impala::Promise<long int>*> > >::operator()(void) (this=0x7c329b8) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/Impala-Toolchain/boost-1.57.0/include/boost/bind/bind_template.hpp:20
      #26 0x00000000015dd0ca in boost::detail::thread_data<boost::_bi::bind_t<void, void (*)(const std::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const std::basic_string<char, std::char_traits<char>, std::allocator<char> >&, boost::function<void()>, impala::Promise<long int>*), boost::_bi::list4<boost::_bi::value<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, boost::_bi::value<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, boost::_bi::value<boost::function<void()> >, boost::_bi::value<impala::Promise<long int>*> > > >::run(void) (this=0x7c32800) at /data/jenkins/workspace/impala-umbrella-build-and-test-isilon/Impala-Toolchain/boost-1.57.0/include/boost/thread/detail/thread.hpp:116
      

        Activity

        Show
        sailesh Sailesh Mukil added a comment - Commit in: https://github.com/apache/incubator-impala/commit/e3483c44a3180a5c1f15a09f7c4f4f7b45ffcb44

          People

          • Assignee:
            sailesh Sailesh Mukil
            Reporter:
            henryr Henry Robinson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development