[IMPALA-4417] The tests/ directory should contain only tests. Common and utility code should go into a testlib/ directory

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: Product Backlog
• Component/s: Infrastructure
• Labels: test-infra
• Assignee: David Knupp
• Reporter: David Knupp
• Created: 02/Nov/16 14:37
• Updated: 08/May/18 18:38

Description

py.test (as does any test framework) contains some way of auto-discovering test functions/classes/etc to run. However, there are many things in the tests/ directory that break py.test's auto-discovery (by falsely appearing to be tests), This necessitates the addition of a white list in tests/run_tests.py as a hack around the breakage.

 # We whitelist valid test directories. If a new test directory is added, update this.
 29 VALID_TEST_DIRS = ['failure', 'query_test', 'stress', 'unittests', 'aux_query_tests',
 30     ┆   ┆   ┆   ┆  'shell', 'hs2', 'catalog_service', 'metadata', 'data_errors',
 31     ┆   ┆   ┆   ┆  'statestore']

We should consider moving anything that is not in this list into a dedicated impala_testlib/ directory. Some of the more obvious candidates include:

tests/common
tests/util
tests/comparison
tests/beeswax
tests/performance

Issue Links

• is related to: IMPALA-6808 Impala python code should be installed into infra/python/env like other packages
• is related to: IMPALA-4420 tests/ directory should be cleaned up