Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4409

ImpalaServer::CancelInternal() can deadlock

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Blocker
    • Resolution: Fixed
    • Impala 2.7.0, Impala 2.8.0
    • Impala 2.8.0
    • Distributed Exec

    Description

      While looking through the code to understand another potential bug, I found out that CancelInternal() violates the lock ordering in ImpalaServer by acquiring SessionState::lock_ while holding QueryExecState::lock_. This could cause a hang if a number of threads were holding the right locks at the right time. I traced out the lock dependencies using a directed graph, which I've attached.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tarmstrong Tim Armstrong
            tarmstrong Tim Armstrong
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment