Details

      Description

      There is a strange Python build failure that happens in our builds, for example
      http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/316/

      Skipping STATS metric impala-server.io.mgr.cached-file-handles-hit-ratio
      Skipping SET metric tmp-file-mgr.active-scratch-dirs.list
      /data/jenkins/workspace/impala-external-gerrit-verify-merge-ASF/repos/Impala/common/thrift/MetricDefs.thrift created.
      Traceback (most recent call last):
        File "/data/jenkins/workspace/impala-external-gerrit-verify-merge-ASF/repos/Impala/common/thrift/generate_metrics.py", line 250, in <module>
          generate_mdl()
        File "/data/jenkins/workspace/impala-external-gerrit-verify-merge-ASF/repos/Impala/common/thrift/generate_metrics.py", line 229, in generate_mdl
          mdl = json.loads(MDL_BASE)
        File "/usr/lib64/python2.6/json/__init__.py", line 307, in loads
          return _default_decoder.decode(s)
        File "/usr/lib64/python2.6/json/decoder.py", line 319, in decode
          obj, end = self.raw_decode(s, idx=_w(s, 0).end())
        File "/usr/lib64/python2.6/json/decoder.py", line 336, in raw_decode
          obj, end = self._scanner.iterscan(s, **kw).next()
        File "/usr/lib64/python2.6/json/scanner.py", line 55, in iterscan
          rval, next_pos = action(m, context)
        File "/usr/lib64/python2.6/json/decoder.py", line 183, in JSONObject
          value, end = iterscan(s, idx=end, context=context).next()
        File "/usr/lib64/python2.6/json/scanner.py", line 55, in iterscan
          rval, next_pos = action(m, context)
        File "/usr/lib64/python2.6/json/decoder.py", line 219, in JSONArray
          raise ValueError(errmsg("Expecting object", s, end))
      ValueError: Expecting object: line 19 column 3 (char 429)
      

      The failure is caused by this command: json.loads(MDL_BASE)
      It's strange because MDL_BASE is a hardcoded string.

        Activity

        Hide
        alex.behm Alexander Behm added a comment -

        I don't think this is breaking builds. It's definitely annoying, but benign.

        Show
        alex.behm Alexander Behm added a comment - I don't think this is breaking builds. It's definitely annoying, but benign.
        Hide
        lv Lars Volker added a comment -

        This was a superfluous comma, I pushed a fix here: https://gerrit.cloudera.org/4887

        Show
        lv Lars Volker added a comment - This was a superfluous comma, I pushed a fix here: https://gerrit.cloudera.org/4887
        Hide
        lv Lars Volker added a comment -

        IMPALA-4330: Fix JSON syntax in generate_metrics.py

        The hardcoded JSON string in MDL_BASE had a superfluous comma, that
        tripped both the simplejson and json parsers. This change removes it so
        the string works with both parsers.

        Change-Id: I98456df28d48ed22cefcc570e88df78fdf441c23
        Reviewed-on: http://gerrit.cloudera.org:8080/4887
        Reviewed-by: Michael Brown <mikeb@cloudera.com>
        Reviewed-by: Jim Apple <jbapple@cloudera.com>
        Reviewed-by: Alex Behm <alex.behm@cloudera.com>
        Tested-by: Internal Jenkins

        Show
        lv Lars Volker added a comment - IMPALA-4330 : Fix JSON syntax in generate_metrics.py The hardcoded JSON string in MDL_BASE had a superfluous comma, that tripped both the simplejson and json parsers. This change removes it so the string works with both parsers. Change-Id: I98456df28d48ed22cefcc570e88df78fdf441c23 Reviewed-on: http://gerrit.cloudera.org:8080/4887 Reviewed-by: Michael Brown <mikeb@cloudera.com> Reviewed-by: Jim Apple <jbapple@cloudera.com> Reviewed-by: Alex Behm <alex.behm@cloudera.com> Tested-by: Internal Jenkins

          People

          • Assignee:
            lv Lars Volker
            Reporter:
            tarasbob Taras Bobrovytsky
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development