Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4320

Use gold linker by default

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: Impala 2.8.0
        • Fix Version/s: Impala 2.8.0
        • Component/s: Infrastructure
        • Labels:
          None

          Description

          We should switch Impala to build using the gold linker by default to speed up builds and improve the experience of new developers.

          We already had a discussion on the dev@ mailing list where people seemed to agree with the idea.

            Activity

            Hide
            Permalink
            tarmstrong Tim Armstrong added a comment -

            ......................................................................

            IMPALA-3420: use gold by default

            Also pass the flag that enables ld.gold directly to the
            compiler. This is understood by both gcc and clang
            (if prefixed with -Wl, clang just forwards the flag to ld,
            where it is ignored).

            Testing:
            Did ASAN and debug private builds to validate it works.
            Tested shared library, release, ninja and distcc builds locally
            as part of my normal workflow.

            Change-Id: Ib05c944ced9cdfe54941f4b690574e45a25110a2
            Reviewed-on: http://gerrit.cloudera.org:8080/4751
            Reviewed-by: Jim Apple <jbapple@cloudera.com>
            Tested-by: Internal Jenkins

            Show
            tarmstrong Tim Armstrong added a comment - ...................................................................... IMPALA-3420 : use gold by default Also pass the flag that enables ld.gold directly to the compiler. This is understood by both gcc and clang (if prefixed with -Wl, clang just forwards the flag to ld, where it is ignored). Testing: Did ASAN and debug private builds to validate it works. Tested shared library, release, ninja and distcc builds locally as part of my normal workflow. Change-Id: Ib05c944ced9cdfe54941f4b690574e45a25110a2 Reviewed-on: http://gerrit.cloudera.org:8080/4751 Reviewed-by: Jim Apple <jbapple@cloudera.com> Tested-by: Internal Jenkins

              People

              • Assignee:
                tarmstrong Tim Armstrong
                Reporter:
                tarmstrong Tim Armstrong
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development