[IMPALA-4246] SleepForMs() utility function has undefined behavior for > 1s

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Impala 2.6.0
• Fix Version/s: Impala 2.8.0
• Component/s: Backend
• Target Version: Impala 2.8.0
• Assignee: Sailesh Mukil
• Reporter: Sailesh Mukil
• Created: 04/Oct/16 20:20
• Updated: 15/Nov/16 13:05
• Resolved: 20/Oct/16 18:34

Description

Our SleepForMs() function relies on usleep() which sleeps for n microseconds. However, the manpage for usleep() specifies that this may not work for values > 1000000 us (or 1s).

SYNOPSIS
...
       int usleep(useconds_t usec);
...

ERRORS
...
       EINVAL usec is not smaller than 1000000.  (On systems where that is considered an error.)

We also do not check the return value of usleep(). This means that sleeps can happen for undefined periods of time depending on the system.

Found this issue after setting a high value for the "kerberos_reinit_interval" flag and noticed that there were very frequent kinit's happening.