Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4239

BufferPoolTest.PinWithoutReservation and BufferPoolTest.CapacityExhausted fail on release build

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: Impala 2.8.0
    • Fix Version/s: Impala 2.8.0
    • Component/s: Backend
    • Labels:

      Description

      http://sandbox.jenkins.sf.cloudera.com/view/Impala/view/Evergreen-asf-master/job/impala-asf-master-exhaustive-release/84/#showFailuresLink

      The two failures may be unrelated, but they may be due to recent changes: IMPALA-3201: in-memory buffer pool implementation, https://github.com/apache/incubator-impala/commit/241c7e01978f180012453b0a4ff6d061ca6d5093

      The previous run of the same job, http://sandbox.jenkins.sf.cloudera.com/view/Impala/view/Evergreen-asf-master/job/impala-asf-master-exhaustive-release/83/#showFailuresLink, also has the same failures. This tests revision 2a31fbdbfac9a7092c96e4ab9894e0db0e4ce9ca which includes
      IMPALA-3201: in-memory buffer pool implementation
      but not the later one, IMPALA-4118: extract encryption utils from BufferedBlockMgr

      Revision tested in test run #84 was 757c68b29e21e64fc4586cdf24ee6f9369be460f, which includes the above change and https://github.com/apache/incubator-impala/commit/757c68b29e21e64fc4586cdf24ee6f9369be460f

      Failures:

      Failed: BufferPoolTest.PinWithoutReservation

      Error Message

      Value of: client_tracker->IncreaseReservationToFit(TEST_BUFFER_LEN)
        Actual: false
      Expected: true
      

      Stacktrace

      /data/jenkins/workspace/impala-umbrella-build-and-test/repos/Impala/be/src/bufferpool/buffer-pool-test.cc:406
      Value of: client_tracker->IncreaseReservationToFit(TEST_BUFFER_LEN)
        Actual: false
      Expected: true
      

      Failed: BufferPoolTest.CapacityExhausted

      Error Message

      Failed
      Bad status: Buffer bytes limit 2048 of buffer pool is exhausted and page eviction is not implemented yet!
      

      Stacktrace

      /data/jenkins/workspace/impala-umbrella-build-and-test/repos/Impala/be/src/bufferpool/buffer-pool-test.cc:540
      Failed
      Bad status: Buffer bytes limit 2048 of buffer pool is exhausted and page eviction is not implemented yet!
      

      The debug exhaustive build, http://sandbox.jenkins.sf.cloudera.com/view/Impala/view/Evergreen-asf-master/job/impala-asf-master-exhaustive/82/, worked and included the first change, so possibly this only fails with a release build.

        Activity

        Hide
        tarmstrong Tim Armstrong added a comment -

        IMPALA-4239: fix buffer pool test failures in release build

        Gtest's ASSERT_DEBUG_DEATH macro has peculiar semantics where in debug
        builds it executes the code in a forked process, so it has no visible
        side-effects, but in release builds it executes the code as normal. This
        makes it difficult to write death tests that work in both debug and
        release builds. To avoid this problem, update our wrapper macro to omit
        the code in release builds (where we can't actually test DCHECKs
        anyway).

        Change-Id: Ia560e702ecac2d29dc72f444645d5a91743c95e3
        Reviewed-on: http://gerrit.cloudera.org:8080/4596
        Reviewed-by: Alex Behm <alex.behm@cloudera.com>
        Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
        Tested-by: Internal Jenkins

        M be/src/testutil/death-test-util.h
        1 file changed, 10 insertions, 0 deletions

        Show
        tarmstrong Tim Armstrong added a comment - IMPALA-4239 : fix buffer pool test failures in release build Gtest's ASSERT_DEBUG_DEATH macro has peculiar semantics where in debug builds it executes the code in a forked process, so it has no visible side-effects, but in release builds it executes the code as normal. This makes it difficult to write death tests that work in both debug and release builds. To avoid this problem, update our wrapper macro to omit the code in release builds (where we can't actually test DCHECKs anyway). Change-Id: Ia560e702ecac2d29dc72f444645d5a91743c95e3 Reviewed-on: http://gerrit.cloudera.org:8080/4596 Reviewed-by: Alex Behm <alex.behm@cloudera.com> Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com> Tested-by: Internal Jenkins — M be/src/testutil/death-test-util.h 1 file changed, 10 insertions , 0 deletions
        Hide
        tarmstrong Tim Armstrong added a comment -

        I see what I did here. This is a test bug not a product bug.

        Show
        tarmstrong Tim Armstrong added a comment - I see what I did here. This is a test bug not a product bug.
        Show
        hsheinblatt_impala_e511 Harrison Sheinblatt added a comment - Same issue happening with cdh release build: http://sandbox.jenkins.sf.cloudera.com/view/Impala/view/Evergreen-cdh5-trunk/job/impala-cdh5-trunk-exhaustive-release/150/

          People

          • Assignee:
            tarmstrong Tim Armstrong
            Reporter:
            hsheinblatt_impala_e511 Harrison Sheinblatt
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development