Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4091

Misconfigured backend unit tests do not generate logs.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Impala 2.6.0, Impala 2.7.0
    • Fix Version/s: Impala 2.8.0
    • Component/s: Infrastructure
    • Labels:
      None

      Description

      Some backend unittests do not follow our standard initialization and as a result do not generate logs logs/be_tests

      Some examples of misbehaving tests:
      runtime-profile-test.cc
      benchmark-test.cc

      The standard initialization looks like this:

      int main(int argc, char** argv) {
        ::testing::InitGoogleTest(&argc, argv);
        impala::InitCommonRuntime(argc, argv, true, impala::TestInfo::BE_TEST);
        impala::InitFeSupport(); // optional
        return RUN_ALL_TESTS();
      }
      

        Activity

        Hide
        alex.behm Alexander Behm added a comment -

        commit f4bbd415e8f0632661937e72da815332a27e412e
        Author: Alex Behm <alex.behm@cloudera.com>
        Date: Thu Sep 8 17:07:20 2016 -0700

        IMPALA-4091: Fix backend unit to log in logs/be_tests.

        1. Many backend unit tests did not follow proper initialization
        using InitCommonRuntime(), and as a result did not write their
        logs into the logs/be_tests directory.

        2. Added an IMPALA_TEST_MAIN() macro that stamps out the common
        main() function used in most gtest unit tests.

        3. Tests added via ADD_UDF_TEST in a CMakeLists.txt did not
        have the logging dir set up properly.

        Testing: I validated that every test produces a corresponding
        .INFO file in logs/be_tests. The only exception is promise-test
        for which I added a TODO since the fix seems non-trivial.

        Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
        Reviewed-on: http://gerrit.cloudera.org:8080/4352
        Reviewed-by: Alex Behm <alex.behm@cloudera.com>
        Tested-by: Internal Jenkins

        Show
        alex.behm Alexander Behm added a comment - commit f4bbd415e8f0632661937e72da815332a27e412e Author: Alex Behm <alex.behm@cloudera.com> Date: Thu Sep 8 17:07:20 2016 -0700 IMPALA-4091 : Fix backend unit to log in logs/be_tests. 1. Many backend unit tests did not follow proper initialization using InitCommonRuntime(), and as a result did not write their logs into the logs/be_tests directory. 2. Added an IMPALA_TEST_MAIN() macro that stamps out the common main() function used in most gtest unit tests. 3. Tests added via ADD_UDF_TEST in a CMakeLists.txt did not have the logging dir set up properly. Testing: I validated that every test produces a corresponding .INFO file in logs/be_tests. The only exception is promise-test for which I added a TODO since the fix seems non-trivial. Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b Reviewed-on: http://gerrit.cloudera.org:8080/4352 Reviewed-by: Alex Behm <alex.behm@cloudera.com> Tested-by: Internal Jenkins

          People

          • Assignee:
            alex.behm Alexander Behm
            Reporter:
            alex.behm Alexander Behm
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development