Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-3955

Remove Scheduler class and rename SimpleScheduler to Scheduler

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Impala 2.6.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Backend
    • Labels:

      Description

      Just for code cleanliness, it would be good to get rid of the Scheduler interface class. There's only one implementation of the interface (SimpleScheduler), and there only ever has been one. If we ever feel it's necessary to have more than one scheduler implementation, we can introduce an appropriate abstraction at that point.

        Activity

        Show
        henryr Henry Robinson added a comment - Fixed by https://github.com/apache/incubator-impala/commit/4743342da1147b09b6bc6cf0322f99026c300952
        Hide
        lv Lars Volker added a comment -

        Henry Robinson - No, right now I cannot think of a reason not to do this. If in the future we want to have multiple schedulers (probably after a clean up of the interface), we can re-introduce a proper interface.

        Show
        lv Lars Volker added a comment - Henry Robinson - No, right now I cannot think of a reason not to do this. If in the future we want to have multiple schedulers (probably after a clean up of the interface), we can re-introduce a proper interface.
        Hide
        henryr Henry Robinson added a comment -

        Lars Volker - any reason we shouldn't do this, in your opinion?

        Show
        henryr Henry Robinson added a comment - Lars Volker - any reason we shouldn't do this, in your opinion?

          People

          • Assignee:
            henryr Henry Robinson
            Reporter:
            henryr Henry Robinson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development