Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-3949

CatalogServiceCatalog.extractFunctions should log the underlying exception when failing to load a function

    Details

      Activity

      Hide
      bharathv bharath v added a comment -

      Commit: 26cf06b53b53ef746da32d3056634e6ff518e340
      IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

      To improve supportability, this commit logs the actual error stack trace
      that can cause FileSystemUtil.copyToLocal() to fail. Additionaly this
      also cleans up FileSystemUtil.isPathReachable() method to throw an
      exception on failures rather than returning false and then returning
      the error message as a string to callers.

      Change-Id: I5664a75aa837951de1d5dcc90e43bd8f313736b8
      Reviewed-on: http://gerrit.cloudera.org:8080/4125
      Reviewed-by: Bharath Vissapragada <bharathv@cloudera.com>
      Tested-by: Internal Jenkins

      M fe/src/main/java/com/cloudera/impala/analysis/HdfsUri.java
      M fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
      M fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java
      M fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java
      4 files changed, 19 insertions, 33 deletions

      Approvals:
      Bharath Vissapragada: Looks good to me, approv

      Show
      bharathv bharath v added a comment - Commit: 26cf06b53b53ef746da32d3056634e6ff518e340 IMPALA-3949 : Log the error message in FileSystemUtil.copyToLocal() To improve supportability, this commit logs the actual error stack trace that can cause FileSystemUtil.copyToLocal() to fail. Additionaly this also cleans up FileSystemUtil.isPathReachable() method to throw an exception on failures rather than returning false and then returning the error message as a string to callers. Change-Id: I5664a75aa837951de1d5dcc90e43bd8f313736b8 Reviewed-on: http://gerrit.cloudera.org:8080/4125 Reviewed-by: Bharath Vissapragada <bharathv@cloudera.com> Tested-by: Internal Jenkins — M fe/src/main/java/com/cloudera/impala/analysis/HdfsUri.java M fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java M fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java 4 files changed, 19 insertions , 33 deletions Approvals: Bharath Vissapragada: Looks good to me, approv
      Hide
      akalaszi Adrian Kalaszi added a comment -

      You may see this related github project which contains an aspect to reveal the hidden stacktrace without the need CDH upgrade:
      https://github.com/akalaszi/CatalogServiceCatalogAspect

      Show
      akalaszi Adrian Kalaszi added a comment - You may see this related github project which contains an aspect to reveal the hidden stacktrace without the need CDH upgrade: https://github.com/akalaszi/CatalogServiceCatalogAspect

        People

        • Assignee:
          bharathv bharath v
          Reporter:
          balazsj_impala_220b Balazs Jeszenszky
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development