Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-391

Expr-test does not actually test the codegen path

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Impala 1.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Backend
    • Labels:
      None

      Description

      Expr-test only tests the codegen but not running the jitted function.

        Activity

        Hide
        skye Skye Wanderman-Milne added a comment -

        pushing out with the rest of the expr refactoring

        Show
        skye Skye Wanderman-Milne added a comment - pushing out with the rest of the expr refactoring
        Hide
        skye Skye Wanderman-Milne added a comment -

        This will happen when we get around to codegening the union node

        Show
        skye Skye Wanderman-Milne added a comment - This will happen when we get around to codegening the union node
        Hide
        tarmstrong Tim Armstrong added a comment -

        Michael Ho this is fixed right?

        Show
        tarmstrong Tim Armstrong added a comment - Michael Ho this is fixed right?
        Hide
        tarmstrong Tim Armstrong added a comment -

        Fixed with this commit

        IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

        This change fixes expr-test.cc to work with codegen as it's
        originally intended. Fixing it uncovers a couple of bugs fixed
        in this patch:
        ...
        Change-Id: I40fdb035a565ae2f9c9fbf4db48a548653ef7608
        Reviewed-on: http://gerrit.cloudera.org:8080/5732
        Reviewed-by: Michael Ho <kwho@cloudera.com>
        Tested-by: Impala Public Jenkins

        Show
        tarmstrong Tim Armstrong added a comment - Fixed with this commit IMPALA-4705 , IMPALA-4779 , IMPALA-4780 : Fix some Expr bugs with codegen This change fixes expr-test.cc to work with codegen as it's originally intended. Fixing it uncovers a couple of bugs fixed in this patch: ... Change-Id: I40fdb035a565ae2f9c9fbf4db48a548653ef7608 Reviewed-on: http://gerrit.cloudera.org:8080/5732 Reviewed-by: Michael Ho <kwho@cloudera.com> Tested-by: Impala Public Jenkins

          People

          • Assignee:
            kwho Michael Ho
            Reporter:
            nong_impala_60e1 Nong Li
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development