Details

      Description

      Impala today includes many mentions of Cloudera, including the Java package names.

      It should move to using only "Apache".

        Activity

        Hide
        jbapple Jim Apple added a comment -

        Also in the copyright headers.

        Show
        jbapple Jim Apple added a comment - Also in the copyright headers.
        Hide
        jbapple Jim Apple added a comment -

        And "CDH" with maybe "Hadoop", where possible

        Show
        jbapple Jim Apple added a comment - And "CDH" with maybe "Hadoop", where possible
        Hide
        dhecht Dan Hecht added a comment -

        I created a separate JIRA about sorting out copyright/license of Cloudera code: IMPALA-3918.
        We can use this one to track specifically package names and comments/strings in the code that contain "Cloudera".

        Show
        dhecht Dan Hecht added a comment - I created a separate JIRA about sorting out copyright/license of Cloudera code: IMPALA-3918 . We can use this one to track specifically package names and comments/strings in the code that contain "Cloudera".
        Show
        jbapple Jim Apple added a comment - For comparison, Kudu's renaming: https://github.com/apache/incubator-kudu/commit/5c305689b301140c8e656af16175e9b3c841cd5c https://github.com/apache/incubator-kudu/commit/81b2d9a7c925174c525a85c04a6ffd5a6d8537f6
        Hide
        twmarshall Thomas Tauber-Marshall added a comment -

        commit b2c2fe7813cbde794acc3dcf9c1d9e937683be72
        Author: Thomas Tauber-Marshall <tmarshall@cloudera.com>
        Date: Fri Aug 12 09:49:06 2016 -0700

        IMPALA-3786: Replace "cloudera" with "apache" (part 2)

        As part of the ASF transition, we need to replace references to
        Cloudera in Impala with references to Apache. This primarily means
        changing Java package names from com.cloudera.impala.* to
        org.apache.impala.*

        A prior patch renamed all the files as necessary, and this patch
        performs the actual code changes. Most of the changes in this patch
        were generated with some commands of the form:

        find . | grep "\.java|\.py|\.h|\.cc" | \
        xargs sed -i s/'com(.)cloudera(\.)impala/org\1apache\2impala/g

        along with some manual fixes.

        After this patch, the remaining references to Cloudera in the repo
        mostly fall into the categories:

        Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2
        Reviewed-on: http://gerrit.cloudera.org:8080/3937
        Reviewed-by: Thomas Tauber-Marshall <tmarshall@cloudera.com>
        Reviewed-by: Jim Apple <jbapple@cloudera.com>
        Tested-by: Internal Jenkins

        commit b544f019aabc1d3aee4368966be8dab478a28f03
        Author: Thomas Tauber-Marshall <tmarshall@cloudera.com>
        Date: Wed Aug 10 15:00:46 2016 -0700

        IMPALA-3786: Replace "cloudera" with "apache" (part 1)

        As part of the ASF transition, we need to replace references to
        Cloudera in Impala with references to Apache. This primarily means
        changing Java package names from com.cloudera.impala.* to
        org.apache.impala.*

        To make this easier to review, this patch only renames files,
        eg. fe/src/main/java/com/cloudera -> fe/src/main/java/org/apache

        A follow up patch performs the actual code updates.

        Change-Id: I3767dd1ee86df767075fdf1b371eb6b0b06668db
        Reviewed-on: http://gerrit.cloudera.org:8080/3936
        Reviewed-by: Thomas Tauber-Marshall <tmarshall@cloudera.com>
        Reviewed-by: Jim Apple <jbapple@cloudera.com>
        Tested-by: Internal Jenkins

        Show
        twmarshall Thomas Tauber-Marshall added a comment - commit b2c2fe7813cbde794acc3dcf9c1d9e937683be72 Author: Thomas Tauber-Marshall <tmarshall@cloudera.com> Date: Fri Aug 12 09:49:06 2016 -0700 IMPALA-3786 : Replace "cloudera" with "apache" (part 2) As part of the ASF transition, we need to replace references to Cloudera in Impala with references to Apache. This primarily means changing Java package names from com.cloudera.impala.* to org.apache.impala.* A prior patch renamed all the files as necessary, and this patch performs the actual code changes. Most of the changes in this patch were generated with some commands of the form: find . | grep "\.java|\.py|\.h|\.cc" | \ xargs sed -i s/'com(.)cloudera(\.)impala/org\1apache\2impala/g along with some manual fixes. After this patch, the remaining references to Cloudera in the repo mostly fall into the categories: External components that have cloudera in their own package names, eg. com.cloudera.kudu/llama URLs, eg. https://repository.cloudera.com/ Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 Reviewed-on: http://gerrit.cloudera.org:8080/3937 Reviewed-by: Thomas Tauber-Marshall <tmarshall@cloudera.com> Reviewed-by: Jim Apple <jbapple@cloudera.com> Tested-by: Internal Jenkins commit b544f019aabc1d3aee4368966be8dab478a28f03 Author: Thomas Tauber-Marshall <tmarshall@cloudera.com> Date: Wed Aug 10 15:00:46 2016 -0700 IMPALA-3786 : Replace "cloudera" with "apache" (part 1) As part of the ASF transition, we need to replace references to Cloudera in Impala with references to Apache. This primarily means changing Java package names from com.cloudera.impala.* to org.apache.impala.* To make this easier to review, this patch only renames files, eg. fe/src/main/java/com/cloudera -> fe/src/main/java/org/apache A follow up patch performs the actual code updates. Change-Id: I3767dd1ee86df767075fdf1b371eb6b0b06668db Reviewed-on: http://gerrit.cloudera.org:8080/3936 Reviewed-by: Thomas Tauber-Marshall <tmarshall@cloudera.com> Reviewed-by: Jim Apple <jbapple@cloudera.com> Tested-by: Internal Jenkins
        Hide
        twmarshall Thomas Tauber-Marshall added a comment -

        commit 8a08850fd42d516c5527899f295222f7c75ad721
        Author: Thomas Tauber-Marshall <tmarshall@cloudera.com>
        Date: Mon Oct 3 16:31:45 2016 -0700

        Revert org.apache.impala.hive.serde.ParquetOutputFormat

        The patch for IMPALA-3786 replaced most instances of
        com.cloudera.impala.* with org.apache.impala.*

        This patch rolls back one such replacement:
        com.cloudera.impala.hive.serde.ParquetOutputFormat
        which is necessary for backwards compatability with previously
        created tables.

        Change-Id: I27738dfc3d44bb5fabd3a066ffbba99527160bce
        Reviewed-on: http://gerrit.cloudera.org:8080/4611
        Reviewed-by: Alex Behm <alex.behm@cloudera.com>
        Tested-by: Internal Jenkins

        Show
        twmarshall Thomas Tauber-Marshall added a comment - commit 8a08850fd42d516c5527899f295222f7c75ad721 Author: Thomas Tauber-Marshall <tmarshall@cloudera.com> Date: Mon Oct 3 16:31:45 2016 -0700 Revert org.apache.impala.hive.serde.ParquetOutputFormat The patch for IMPALA-3786 replaced most instances of com.cloudera.impala.* with org.apache.impala.* This patch rolls back one such replacement: com.cloudera.impala.hive.serde.ParquetOutputFormat which is necessary for backwards compatability with previously created tables. Change-Id: I27738dfc3d44bb5fabd3a066ffbba99527160bce Reviewed-on: http://gerrit.cloudera.org:8080/4611 Reviewed-by: Alex Behm <alex.behm@cloudera.com> Tested-by: Internal Jenkins
        Hide
        jbapple Jim Apple added a comment -

        There is still KUDU_STORAGE_HANDLER in KuduTable.java. Is that intentional? I think Kudu has started using apache package names.

        Same goes for com.cloudera.kudu.hive.KuduStorageHandler in AnalyzeDDLTest.java and generate-schema-statements.py, etc.

        cc: Matthew Jacobs, who might know more about the Kudu package name that should be used.

        Show
        jbapple Jim Apple added a comment - There is still KUDU_STORAGE_HANDLER in KuduTable.java. Is that intentional? I think Kudu has started using apache package names. Same goes for com.cloudera.kudu.hive.KuduStorageHandler in AnalyzeDDLTest.java and generate-schema-statements.py, etc. cc: Matthew Jacobs , who might know more about the Kudu package name that should be used.

          People

          • Assignee:
            twmarshall Thomas Tauber-Marshall
            Reporter:
            jbapple Jim Apple
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development