[IMPALA-3551] Fix ThriftClient initialization code

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: Impala 2.3.0, Impala 2.5.0, Impala 2.4.0, Impala 2.6.0
• Component/s: Distributed Exec
• Labels: kerberos ramp-up rpc thrift
• Target Version: Product Backlog
• Assignee: Tim Armstrong
• Reporter: Matthew Jacobs
• Created: 17/May/16 05:57
• Updated: 22/Dec/20 19:13
• Resolved: 22/Dec/20 19:13

Description

The ThriftClient constructor has a few issues:

• All errors need to be handled. The result of auth_provider_->WrapClientTransport() is ignored.
• Logic that can fail should be moved to an initialization method. Calling code would need to be updated.
• Failure conditions should be tested. Right now we don't have confidence in making the above changes.

This came up in the context of fixing IMPALA-1928, which had to be addressed in a minimal way since we don't have enough test coverage. See this review for some more context: http://gerrit.cloudera.org:8080/#/c/3093/