Details

      Description

      Impala's gerrit-verify-merge script kicks off a pre-commit set of jobs for a particular patch, and then submits that patch if they are successful. All committers should be able to run that job (so IMPALA-3227 is of great importance for visibility here).

      We should move that script into the main Impala repository (along with any other scripts that are useful for the standard workflow). Any dependencies on the Impala auxiliary script repository should be removed.

        Issue Links

          Activity

          Hide
          alex.behm Alexander Behm added a comment -

          Jim Apple is the plan to run the same set of tests on ASF? Are we going to move all GVOs to that new infrastructure? How are we not going to overload it?

          Show
          alex.behm Alexander Behm added a comment - Jim Apple is the plan to run the same set of tests on ASF? Are we going to move all GVOs to that new infrastructure? How are we not going to overload it?
          Hide
          jbapple Jim Apple added a comment -

          1. It seems to me that it would be good to run as many of the current tests as possible. What do you think?

          2. I think it would be best to move all GVOs over, that way there can't be a conflict where a patch passes one GVO consistently but fails the other consistently.

          3. Do you think our current GVO load will necessarily overload any external CI setup?

          Show
          jbapple Jim Apple added a comment - 1. It seems to me that it would be good to run as many of the current tests as possible. What do you think? 2. I think it would be best to move all GVOs over, that way there can't be a conflict where a patch passes one GVO consistently but fails the other consistently. 3. Do you think our current GVO load will necessarily overload any external CI setup?
          Show
          jbapple Jim Apple added a comment - http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/
          Hide
          jbapple Jim Apple added a comment -

          This is a bulk comment on all issues with Fix Version 2.8.0 that were resolved on or after 2016-12-09.

          2.8.0 was branched on December 9, with only two changes to master cherry-picked to the 2.8.0 release branch after that:

          https://github.com/apache/incubator-impala/commits/2.8.0

          Issues fixed after December 9 might not be fixed in 2.8.0. If you are the one who marked this issue Resolved, can you check to see if the patch is in 2.8.0 by using the link above? If the patch is not in 2.8.0, can you change the Fix Version to 2.9.0?

          Thank you!

          Show
          jbapple Jim Apple added a comment - This is a bulk comment on all issues with Fix Version 2.8.0 that were resolved on or after 2016-12-09. 2.8.0 was branched on December 9, with only two changes to master cherry-picked to the 2.8.0 release branch after that: https://github.com/apache/incubator-impala/commits/2.8.0 Issues fixed after December 9 might not be fixed in 2.8.0. If you are the one who marked this issue Resolved, can you check to see if the patch is in 2.8.0 by using the link above? If the patch is not in 2.8.0, can you change the Fix Version to 2.9.0? Thank you!

            People

            • Assignee:
              tarasbob Taras Bobrovytsky
              Reporter:
              henryr Henry Robinson
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development