[IMPALA-3135] test_hash_join_timer can take longer than upper bound for instrumented builds (code coverage)

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Duplicate
• Affects Version/s: Impala 2.5.0
• Component/s: Infrastructure
• Labels: broken-build test_issue
• Environment: 2.6 code coverage jenkins job
• Target Version: Product Backlog
• Assignee: Unassigned
• Reporter: Harrison Sheinblatt
• Created: 04/Mar/16 00:19
• Updated: 04/Mar/16 02:28
• Resolved: 04/Mar/16 02:28

Description

The HASH_JOIN_UPPER_BOUND_MS is set to 1000 ms in tests/query_test/test_hash_join_timer.py. For a code coverage build, the time taken was 1298 ms.

Error Message

AssertionError: Hash join timing too high for ExecSummary Avg: 1s298ms 1298.0 assert False

Stacktrace

query_test/test_hash_join_timer.py:107: in test_hash_join_timer
    self.__verify_join_time(columns[1], "ExecSummary Avg")
query_test/test_hash_join_timer.py:129: in __verify_join_time
    assert False, "Hash join timing too high for %s: %s %s" %(comment, duration, duration_ms)
E   AssertionError: Hash join timing too high for ExecSummary Avg: 1s298ms 1298.0
E   assert False

Standard Error

SET disable_codegen=False;
SET abort_on_error=1;
SET exec_single_node_rows_threshold=0;
SET batch_size=0;
SET num_nodes=0;
-- executing async: localhost:21000
select /*+straight_join*/ count(*) from (select distinct * from functional.alltypes where int_col >= sleep(5)) a cross join  functional.alltypes b where a.id > b.id and b.id=99;

-- getting state for operation: <tests.common.impala_connection.OperationHandle object at 0x81c4210>
-- getting state for operation: <tests.common.impala_connection.OperationHandle object at 0x81c4210>
-- getting state for operation: <tests.common.impala_connection.OperationHandle object at 0x81c4210>
-- getting state for operation: <tests.common.impala_connection.OperationHandle object at 0x81c4210>
-- getting state for operation: <tests.common.impala_connection.OperationHandle object at 0x81c4210>
-- closing query for operation handle: <tests.common.impala_connection.OperationHandle object at 0x81c4210>
-- getting runtime profile operation: <tests.common.impala_connection.OperationHandle object at 0x81c4210>

This is well within the slowdown expected for an instrumented build. We either need to change the bound based on the type of build/configuration or remove this test from instrumented runs.