[IMPALA-2914] Hit DCHECK Check failed: HasDateOrTime()

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: Impala 2.2
• Fix Version/s: Impala 2.5.0, Impala 2.2.10, Impala 2.3.4
• Component/s: Backend
• Labels: crash
• Target Version: Impala 2.5.0, Impala 2.3.4
• Assignee: Juan Yu
• Reporter: Juan Yu
• Created: 01/Feb/16 17:12
• Updated: 19/Apr/16 07:02
• Resolved: 23/Feb/16 18:47

Description

TimestampValue::ToTimestampVal() require input is a valid TimestampValue.

  // Returns a TimestampVal representation in the output variable. The caller must ensure
  // the TimestampValue instance has a valid date or time before calling.
void ToTimestampVal(impala_udf::TimestampVal* tv) const {
    DCHECK(HasDateOrTime());

However in quite a few place, caller doesn't guarantee this. for example:

TimestampVal DecimalOperators::CastToTimestampVal(
    FunctionContext* context, const DecimalVal& val) {
  if (val.is_null) return TimestampVal::null();
  ColumnType val_type = AnyValUtil::TypeDescToColumnType(*context->GetArgType(0));
  DCHECK_EQ(val_type.type, TYPE_DECIMAL);
  TimestampVal result;
  switch (val_type.GetByteSize()) {
    case 4: {
      Decimal4Value dv(val.val4);
      TimestampValue tv(dv.ToDouble(val_type));
      tv.ToTimestampVal(&result);
      break;
    }

This cause a DCHECK failure. and crash if debug build is used.