Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-2864

Ensure that client connections are closed after a failed RPC and a failed Open()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Impala 2.3.0
    • Fix Version/s: Impala 2.8.0
    • Component/s: Distributed Exec
    • Labels:
      None

      Description

      In ClientConnection::DoRpc() there are some paths that don't explicitly Close() a client connection after failure. We should do this to ensure a simple postcondition for the method, and to ensure that connection state is properly reinitialised on the next use.

      Similarly, on ThriftClientImpl:Open(), transport_->open() while using SASL actually opens the socket but the call could still throw an exception because of other failures in the SASL framework. To make sure that the socket is not left open on an exception, we explicitly call close() on the socket.

        Issue Links

          Activity

          Hide
          tarmstrong Tim Armstrong added a comment -

          Should this still be open? There's a patch already merged: https://gerrit.cloudera.org/#/c/1599/

          Show
          tarmstrong Tim Armstrong added a comment - Should this still be open? There's a patch already merged: https://gerrit.cloudera.org/#/c/1599/
          Hide
          henryr Henry Robinson added a comment -

          Sailesh Mukil - anything left to do here?

          Show
          henryr Henry Robinson added a comment - Sailesh Mukil - anything left to do here?
          Hide
          sailesh Sailesh Mukil added a comment -

          Tim Armstrong Henry Robinson, the patch isn't merged yet. It still hasn't received a +2. We de-prioritized this a while back because we fixed issues in Impala which would expose this issue. But now seeing that other configuration issues (non-Impala specific, like bad ifconfigs ,etc.) , can expose this problem, we should probably try to get this in.

          Show
          sailesh Sailesh Mukil added a comment - Tim Armstrong Henry Robinson , the patch isn't merged yet. It still hasn't received a +2. We de-prioritized this a while back because we fixed issues in Impala which would expose this issue. But now seeing that other configuration issues (non-Impala specific, like bad ifconfigs ,etc.) , can expose this problem, we should probably try to get this in.
          Show
          sailesh Sailesh Mukil added a comment - Commit in: https://github.com/apache/incubator-impala/commit/a65864a40ddc73aebeaf04abb5c5ca6fa70ba0ee

            People

            • Assignee:
              sailesh Sailesh Mukil
              Reporter:
              henryr Henry Robinson
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development