Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-2864

Ensure that client connections are closed after a failed RPC and a failed Open()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Impala 2.3.0
    • Fix Version/s: Impala 2.8.0
    • Component/s: Distributed Exec
    • Labels:
      None

      Description

      In ClientConnection::DoRpc() there are some paths that don't explicitly Close() a client connection after failure. We should do this to ensure a simple postcondition for the method, and to ensure that connection state is properly reinitialised on the next use.

      Similarly, on ThriftClientImpl:Open(), transport_->open() while using SASL actually opens the socket but the call could still throw an exception because of other failures in the SASL framework. To make sure that the socket is not left open on an exception, we explicitly call close() on the socket.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                sailesh Sailesh Mukil
                Reporter:
                henryr Henry Robinson
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: