[IMPALA-2195] Improper handling of comments in queries

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 2.2, Impala 2.3.0
• Fix Version/s: Impala 2.13.0, Impala 3.1.0
• Component/s: Clients
• Labels: shell
• Target Version: Product Backlog
• Assignee: Fredy Wijaya
• Reporter: Bharath Vissapragada
• Created: 10/Aug/15 19:03
• Updated: 21/Mar/19 22:31
• Resolved: 14/Jun/18 21:22

Description

Shell doesn't handle comments properly while executing the queries. For example,

[impalad:21000] > ----- random comment 1
-----### random comment 2
insert overwrite test2 select * from test1;
Query: ----- random comment 1
-----### random comment 2
insert overwrite test2 select * from test1

Fetched 0 row(s) in 3.53s

Stderr for an insert query shows up as "Fetched 0 row(s)" instead of "Inserted 1 row(s)" . This happens because the shell parser doesn't detect this as an insert query due to the presence of comments. We don't strip the comments before sending them to Cmd control, due which the default() method is applied instead of do_insert().