[IMPALA-2130] hdfs-parquet-scanner's verification of file version is not correct

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Impala 2.2
• Fix Version/s: Impala 2.3.0, Impala 2.2.8
• Labels: ramp-up
• Target Version: Impala 2.3.0, Impala 2.2.8
• Assignee: Ippokratis Pandis
• Reporter: Nong Li
• Created: 08/Jul/15 19:45
• Updated: 04/Jan/17 23:58
• Resolved: 14/Jul/15 05:27

Description

The latest version of clang found this as a warning.

HdfsParquetScanner::ProcessFooter() {
...
if (memcmp(magic_number_ptr,
      PARQUET_VERSION_NUMBER, sizeof(PARQUET_VERSION_NUMBER) != 0)) { <-- paren in wrong place, not comparing the right number of bytes.
    return Status(Substitute("File $0 is invalid.  Invalid file footer: $1",
        stream_->filename(),
        string((char*)magic_number_ptr, sizeof(PARQUET_VERSION_NUMBER))));
  }
}