Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-2130

hdfs-parquet-scanner's verification of file version is not correct

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • Impala 2.2
    • Impala 2.3.0, Impala 2.2.8
    • None

    Description

      The latest version of clang found this as a warning.

      HdfsParquetScanner::ProcessFooter() {
      ...
      if (memcmp(magic_number_ptr,
            PARQUET_VERSION_NUMBER, sizeof(PARQUET_VERSION_NUMBER) != 0)) { <-- paren in wrong place, not comparing the right number of bytes.
          return Status(Substitute("File $0 is invalid.  Invalid file footer: $1",
              stream_->filename(),
              string((char*)magic_number_ptr, sizeof(PARQUET_VERSION_NUMBER))));
        }
      }
      

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ippokratis Ippokratis Pandis
            nong_impala_60e1 Nong Li
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment