Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-1925

Evaluate whether any target platform still needs to link against -mt Boost libs

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Impala 2.2
    • Product Backlog
    • None
    • None

    Description

      Impala links against regex-mt, filesystem-mt and system-mt from Boost. On newer distributions (e.g. Ubuntu), the -mt libraries have been removed since the base libraries are thread-safe. This means Impala won't build on those systems without either a code change, or a symlink from the base libraries to their -mt equivalents.

      We should figure out if any of our supported platforms require linking against -mt, and if not, update the linker script.

      Attachments

        Activity

          dhecht Daniel Hecht added a comment -

          Do you know the answer?

          dhecht Daniel Hecht added a comment - Do you know the answer?
          mgrund_impala_bb91 Martin Grund added a comment -

          We should get rid of this for the following reasons:

          1) On all modern OS versions the untagged layout is used
          2) For production we build against a custom built boost that uses symlinks to the -mt version.

          Below a snip from the kitchen toolchain folder that we use to link boost from.

          -rw-r--r-- 1 root root 191K Sep  4  2014 libboost_filesystem.a
          lrwxrwxrwx 1 root root   21 Sep  4  2014 libboost_filesystem-mt.a -> libboost_filesystem.a
          

          Which means, since we're already "testing" this in produciton, we're fine.

          mgrund_impala_bb91 Martin Grund added a comment - We should get rid of this for the following reasons: 1) On all modern OS versions the untagged layout is used 2) For production we build against a custom built boost that uses symlinks to the -mt version. Below a snip from the kitchen toolchain folder that we use to link boost from. -rw-r--r-- 1 root root 191K Sep 4 2014 libboost_filesystem.a lrwxrwxrwx 1 root root 21 Sep 4 2014 libboost_filesystem-mt.a -> libboost_filesystem.a Which means, since we're already "testing" this in produciton, we're fine.
          henryr Henry Robinson added a comment -

          Great, let's use the patch from IMPALA-2012 then and close this.

          henryr Henry Robinson added a comment - Great, let's use the patch from IMPALA-2012 then and close this.

          People

            mgrund_impala_bb91 Martin Grund
            henryr Henry Robinson
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: