[IMPALA-191] Support /* */ comments

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 0.7
• Fix Version/s: Impala 1.0
• Component/s: Clients
• Labels: shell
• Assignee: Ishaan Joshi
• Reporter: John Russell
• Created: 04/Apr/13 18:08
• Updated: 28/Dec/15 17:43
• Resolved: 23/Apr/13 18:06

Description

It is very common for command shells for Oracle or MySQL databases to support both - single-line and /* / multi-line comment notation. 'impala-shell -f blah.sql' currently gives 'unrecognized command' for /* */ comments. It should silently ignore them. (It does

For example, the basic MySQL sample code here: http://downloads.mysql.com/docs/world.sql.zip
immediately gives a bunch of 'unrecognized command' errors due to a mix of - and /* */ comments at the top of the file, regardless of whether the actual SQL command syntax is compatible or not.

Based on the pattern of error messages, it seems like Impala really does ignore whatever is in between the /* / delimiters, so it might just be a case of spurious messages when it actually encounters / and */.