[IMPALA-1756] Constant expressions not checked for errors, no state cleanup on exception.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.1.1
• Fix Version/s: Impala 2.2.7, Impala 2.3.0
• Labels: correctness
• Target Version: Impala 2.2.7, Impala 2.3.0
• Assignee: Sailesh Mukil
• Reporter: Grant Henke
• Created: 12/Feb/15 19:11
• Updated: 01/Oct/15 19:08
• Resolved: 24/Jul/15 19:32

Description

Constant filter expressions are evaluated during query compilation, and not during execution. When evaluating those expressions during compilation, there is no check whether there is an error set or not.

Specifically, errors are not checked after GetConstVal() is called in ScalarFnCall::Open(). Also, in NativeEvalConstExprs in fe-support.cc, if an error takes place during evaluation in Open() or GetValue(), the state is not cleaned up (Close() is not called) before throwing an exception.