[IMPALA-1656] Remove block_mgr_client_ != NULL checks

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.1
• Fix Version/s: Impala 2.5.0
• Labels: ramp-up
• Target Version: Product Backlog
• Assignee: Tim Armstrong
• Reporter: Ippokratis Pandis
• Created: 13/Jan/15 02:58
• Updated: 04/Jan/17 23:58
• Resolved: 16/Dec/15 03:47

Description

In various places in BE's code there are checks like the one below that use the block_mgr_ only if this is set. This is because some tests do not setup the whole ExecEnv. But that adds complexity and branches. We should remove them, making sure that all tests have a properly setup environment (and DCHECK_NOTNULL(block_mgr_client_)).

  if (block_mgr_client_ != NULL) {
    state_->block_mgr()->ReleaseMemory(block_mgr_client_, old_size);
  }

Issue Links

• is a child of: IMPALA-2755 Clean up memory management in backend