[IMPALA-13400] Incomplete ResourceProfile at multi-class AggregationNode

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: Impala 4.4.0
• Component/s: Frontend
• Target Version: Impala 4.5.0
• Epic Color: ghx-label-9
• Assignee: Riza Suminto
• Reporter: Riza Suminto
• Created: 24/Sep/24 02:22
• Updated: 24/Sep/24 02:51
• Resolved: 24/Sep/24 02:51

Description

AggregationNode.computeAggClassResourceProfile() call setSpillableBufferBytes and setMaxRowBufferBytes. However, ResourceProfile for each aggregation class are merged using ResourceProfile.sum() which waive setting both fields.

https://github.com/apache/impala/blob/7167f3b4f0b6940f36705c95b8da17941557f721/fe/src/main/java/org/apache/impala/planner/AggregationNode.java#L605 

https://github.com/apache/impala/blob/7167f3b4f0b6940f36705c95b8da17941557f721/fe/src/main/java/org/apache/impala/planner/ResourceProfile.java#L151 

It should use ResourceProfile.combine() that will pick max 
SpillableBufferBytes and max MaxRowBufferBytes.