Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-13323

Remove redundant tests in test_join_queries.py

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • Impala 4.4.0
    • Impala 4.5.0
    • Test
    • None

    Description

      test_join_queries.py is expensive to run in exhaustive exploration because it run many test dimension permutation, but actually never exercise some of the dimensions. Those redundant tests are follows:

      • Have mt_dop dimension, but not exercising it:
        test_outer_to_inner_joins
        test_single_node_nested_loop_joins
      • Have batch_size dimension but not exercising it:
        test_outer_to_inner_joins
        test_single_node_nested_loop_joins
        test_single_node_nested_loop_joins_exhaustive
        test_semi_joins_exhaustive
      • Have enable_outer_join_to_inner_transformation dimension but not exercising it:
        All TestJoinQueries except test_outer_to_inner_joins

      test_miss_tuple_joins is also valid to run with much fewer test dimension because it mainly test correctness of predicate pushdown during planning.

      Attachments

        Activity

          People

            rizaon Riza Suminto
            rizaon Riza Suminto
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: