[IMPALA-13319] Avoid duplicate exec option declaration in py.test

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 4.4.0
• Fix Version/s: Impala 4.5.0
• Component/s: Test
• Target Version: Impala 4.5.0
• Epic Color: ghx-label-13
• Assignee: Riza Suminto
• Reporter: Riza Suminto
• Created: 22/Aug/24 00:12
• Updated: 23/Aug/24 07:27
• Resolved: 23/Aug/24 05:10

Description

add_mandatory_exec_option() may replace existing option values in 'exec_option' dimension, and may cause unintended test vector duplication. For example, the following declaration will create two duplicate test vector, both with "disable_codegen=False":

    cls.ImpalaTestMatrix.add_dimension(create_exec_option_dimension(
      disable_codegen_options=[False, True]))
    add_mandatory_exec_option(cls, "disable_codegen", False)

 

add_exec_option_dimension() will create new test dimension for a 'key', but does not insert it into 'exec_option' dimension until vector generation later. It also does not validate if 'key' already exist in 'exec_option' dimension. This can confuse test writer when they need to write constraint, because they might look for the value at vector.get_value('exec_option')['key'] instead of vector.get_value('key'), and vice versa.