[IMPALA-13264] bin/coverage_helper.sh should always use gcov from the toolchain

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 4.5.0
• Fix Version/s: Impala 4.5.0
• Component/s: Infrastructure
• Epic Color: ghx-label-5
• Assignee: Joe McDonnell
• Reporter: Joe McDonnell
• Created: 31/Jul/24 17:24
• Updated: 19/Aug/24 17:09
• Resolved: 19/Aug/24 17:09

Description

bin/coverage_helper.sh gets gcov from the toolchain if it is not installed on the system.

if ! which gcov > /dev/null; then
  export PATH="$PATH:$IMPALA_TOOLCHAIN_PACKAGES_HOME/gcc-$IMPALA_GCC_VERSION/bin"
fi
echo "Using gcov at `which gcov`"

Since the toolchain compiler can be different from the system compiler, I think it makes more sense to always use gcov from the toolchain's GCC. Then the gcov version will always match the GCC version.