[IMPALA-11674] Fix IsPeekTimeoutTException and IsReadTimeoutTException for thrift-0.16.0

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 4.2.0
• Fix Version/s: Impala 4.2.0
• Component/s: Backend
• Target Version: Impala 4.2.0
• Epic Color: ghx-label-6
• Assignee: Riza Suminto
• Reporter: Wenzhe Zhou
• Created: 18/Oct/22 17:57
• Updated: 31/Oct/22 04:48
• Resolved: 21/Oct/22 12:58

Description

IMPALA-7825 upgraded Thrift version from 0.9.3 to 0.11.0, IMPALA-11384 upgraded CPP Thrift components from 0.11.0 to Thrift-0.16.0.
Functions IsPeekTimeoutTException() and IsReadTimeoutTException() in be/src/rpc/thrift-util.cc make assumption about the implementation of read(), peek(), write() and write_partial() in TSocket.cpp and TSSLSocket.cpp. The functions read() and peek() in TSSLSocket.cpp were changed in version 0.11.0 and 0.16.0 to throw different exception for timeout. This cause IsPeekTimeoutTException() and IsReadTimeoutTException() to return wrong value after upgrade thrift, which in turn cause TAcceptQueueServer::Peek() to rethrow the exception to caller TAcceptQueueServer::run() and make TAcceptQueueServer::run() to close the connection.